From 5adffa613619eea42405d0cfdb402705e0f4751f Mon Sep 17 00:00:00 2001 From: Gabriel Schneider Date: Fri, 13 Nov 2026 12:30:37 -0300 Subject: debugger: make hexdump pointer bytes clickable in every integer grouping Publish full pointer spans from the shared byte renderer and grouped numeric rows. Both mouse buttons now use the existing lens/navigation handlers even in 8-bit view, including zero padding. Reject pointer hits when any constituent byte is uncaptured. Verified native/headless left and right clicks, recursive lenses, stack destinations, and GUI/shared-renderer suites. --- gui/test/lenses.py | 42 ++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 42 insertions(+) (limited to 'gui/test') diff --git a/gui/test/lenses.py b/gui/test/lenses.py index c78e250..9d287fa 100644 --- a/gui/test/lenses.py +++ b/gui/test/lenses.py @@ -83,6 +83,46 @@ click 1278 822 expect number_format float click 1278 822 expect number_format hex +''' + # Pointer hits cover the full eight-byte field, independently of grouping. + for unit in (1, 2, 4, 8): + commands += f'''console memory-format {unit} hex +console goto memory {head} +frames 40 +click 1270 863 +expect lens_count 1 +expect lenses[0].address {symbols['middle']} +key escape +console mouse-button 3 1270 863 +expect focus memory +expect nav[2].place.address {symbols['middle']} +''' + commands += f'''console memory-format 1 hex +console goto memory {head} +frames 40 +# The last (zero) byte of a little-endian pointer follows the full pointer too. +click 1480 863 +expect lenses[0].address {symbols['middle']} +frames 30 +# The pointer's bytes in a recursive lens use the same shared hit geometry. +click 1250 231 +expect lens_count 2 +expect lenses[1].address {symbols['tail']} +key escape +# A stack pointer stored in ordinary data routes by its target mapping. +console goto memory {symbols['stack_pointer']} +frames 40 +click {1270 + (symbols['stack_pointer'] % 16) * 30 + (12 if symbols['stack_pointer'] % 16 >= 8 else 0)} 863 +expect lens_count 1 +print lenses[0].address +key escape +console mouse-button 3 {1270 + (symbols['stack_pointer'] % 16) * 30 + (12 if symbols['stack_pointer'] % 16 >= 8 else 0)} 863 +expect focus stack +print nav[1].place.address +expect nav[1].place.follow false +expect execution 1 +console goto memory {head} +frames 40 ''' for unit in (1, 2, 4, 8): for fmt in ('hex', 'unsigned', 'signed') + (('float',) if unit >= 4 else ()): @@ -114,6 +154,8 @@ expect-no-log backdrop shader assert run.returncode == 0, stderr first = int(re.search(r'lenses\[0\].first = (\d+)', stderr)[1]) assert first > code, (first, code) + stack_addresses = re.findall(r'(?:lenses\[0\].address|nav\[1\].place.address) = (\d+)', stderr) + assert len(stack_addresses) == 2 and stack_addresses[0] == stack_addresses[1], stack_addresses stops = re.findall(r'stops = (\d+)', stderr) assert len(stops) == 2 and stops[0] == stops[1], stops for recording in Path('/tmp').glob(f'ztrace-gui-{run.pid}-*.ztrace'): -- cgit v1.3