From d2a066ea4ffe4388fe0da71bd8389649ac59b73f Mon Sep 17 00:00:00 2001 From: Gabriel Schneider Date: Thu, 5 Nov 2026 00:49:57 -0300 Subject: host_io: the image, PDF and syntax subsystems a session draws with start and stop in one place (startWorkers, stopWorkers), where the tty's local session, the window's session and its test grid each started them and deferred their stop in eleven lines of their own Co-Authored-By: Claude Opus 5.5 Claude-Session: https://claude.ai/code/session_016Y9MNAtZenFv4weoMD3cge --- src/gui/gui.zig | 26 ++++---------------------- src/host_io.zig | 21 +++++++++++++++++++++ src/tui/tui.zig | 13 ++----------- 3 files changed, 27 insertions(+), 33 deletions(-) diff --git a/src/gui/gui.zig b/src/gui/gui.zig index a7095f6e..711f0657 100644 --- a/src/gui/gui.zig +++ b/src/gui/gui.zig @@ -2371,17 +2371,8 @@ fn localSession( const gpa = init.gpa; const allocs = pardes.memory.init(gpa); defer pardes.memory.deinit(); - pardes.image.start(io, allocs.image); // stb_image allocator for image panes - if (comptime pardes.pdf_enabled) pardes.pdf.start(allocs.pdf); - // Pages render on lanes off the loop (pdf_view.workers). - if (comptime pardes.pdf_enabled) pardes.panes.Pdf.workers = io; - pardes.syntax.start(allocs.tree_sitter); - defer { - pardes.image.stop(); - if (comptime pardes.pdf_enabled) pardes.panes.Pdf.dropKept(); - if (comptime pardes.pdf_enabled) pardes.pdf.stop(); - pardes.syntax.stop(); - } + host_io.startWorkers(io, allocs); + defer host_io.stopWorkers(); var opts = opts_in; opts.image_allocator = allocs.image; opts.pdf_allocator = allocs.pdf; @@ -2916,17 +2907,8 @@ fn runGrid(init: std.process.Init, opts_in: pardes.Options) !void { const allocs = pardes.memory.init(gpa); defer pardes.memory.deinit(); - pardes.image.start(io, allocs.image); - if (comptime pardes.pdf_enabled) pardes.pdf.start(allocs.pdf); - // Pages render on lanes off the loop (pdf_view.workers). - if (comptime pardes.pdf_enabled) pardes.panes.Pdf.workers = io; - pardes.syntax.start(allocs.tree_sitter); - defer { - pardes.image.stop(); - if (comptime pardes.pdf_enabled) pardes.panes.Pdf.dropKept(); - if (comptime pardes.pdf_enabled) pardes.pdf.stop(); - pardes.syntax.stop(); - } + host_io.startWorkers(io, allocs); + defer host_io.stopWorkers(); const grid_cols = envU16(env, "PARDES_TEST_COLS") orelse 80; const grid_rows = envU16(env, "PARDES_TEST_ROWS") orelse 24; diff --git a/src/host_io.zig b/src/host_io.zig index 97e6cbbc..d6b9b72e 100644 --- a/src/host_io.zig +++ b/src/host_io.zig @@ -75,6 +75,27 @@ pub fn testClock() ?u64 { return if (libc.getenv("PARDES_TEST_CLOCK")) |v| (if (std.mem.span(v).len != 0) 0 else null) else null; } +/// The image, PDF and syntax subsystems a frontend's session draws with, +/// on `allocs` (pardes.memory.init); PDF pages render on lanes off the +/// loop (pdf_view.workers). `stopWorkers` is its defer. +pub fn startWorkers(io: std.Io, allocs: pardes.memory.Allocators) void { + pardes.image.start(io, allocs.image); + if (comptime pardes.pdf_enabled) { + pardes.pdf.start(allocs.pdf); + pardes.panes.Pdf.workers = io; + } + pardes.syntax.start(allocs.tree_sitter); +} + +pub fn stopWorkers() void { + pardes.image.stop(); + if (comptime pardes.pdf_enabled) { + pardes.panes.Pdf.dropKept(); + pardes.pdf.stop(); + } + pardes.syntax.stop(); +} + pub const Fallback = struct { pub const dump_path = "pardes.dump"; diff --git a/src/tui/tui.zig b/src/tui/tui.zig index 8b4de782..d0e923a1 100644 --- a/src/tui/tui.zig +++ b/src/tui/tui.zig @@ -1605,17 +1605,8 @@ fn localSession( options.tree_sitter_allocator = allocs.tree_sitter; options.frame_allocator = allocs.frame; - pardes.image.start(io, allocs.image); - if (comptime pardes.pdf_enabled) pardes.pdf.start(allocs.pdf); - // Pages render on lanes off the loop (pdf_view.workers). - if (comptime pardes.pdf_enabled) pardes.panes.Pdf.workers = io; - pardes.syntax.start(allocs.tree_sitter); - defer { - pardes.image.stop(); - if (comptime pardes.pdf_enabled) pardes.panes.Pdf.dropKept(); - if (comptime pardes.pdf_enabled) pardes.pdf.stop(); - pardes.syntax.stop(); - } + host_io.startWorkers(io, allocs); + defer host_io.stopWorkers(); var core = if (upgrade.resumed) |*rec| try upgrade.load(gpa, allocs.pardes, options, rec) -- cgit v1.3