From eece0fbe709142f6731b7dd2e84009c3a18a3806 Mon Sep 17 00:00:00 2001 From: Gabriel Schneider Date: Tue, 29 Sep 2026 02:20:43 -0300 Subject: A pane closed with its question standing logs answer - A follower that saw ask never heard the question end when its pane closed first. Retiring a pane with a question still up now logs answer - before its del. Co-Authored-By: Claude Opus 5.5 --- docs/fs.md | 2 +- src/ninep/events.zig | 6 ++++++ src/pardes.zig | 11 +++++++++++ 3 files changed, 18 insertions(+), 1 deletion(-) diff --git a/docs/fs.md b/docs/fs.md index d8080e1c..64f10e21 100644 --- a/docs/fs.md +++ b/docs/fs.md @@ -611,7 +611,7 @@ since a terminal is named by its directory), `exit ` before the `del` of a terminal whose shell exited by itself, `ask ` when a pane asks a question (answered by `answer` on its ctl), `answer ` when it is answered, by key or ctl, `-` for -taken back, +taken back or for its pane closing with the question standing, and `save `, `dump ` when a Dump is written and `restore ` in a Restore's new log after its panes' `new`s, then `restored ` for each pane, diff --git a/src/ninep/events.zig b/src/ninep/events.zig index 2112110a..61aadae2 100644 --- a/src/ninep/events.zig +++ b/src/ninep/events.zig @@ -122,6 +122,12 @@ pub fn noteRetire(p: *Pardes, pane: *Pane) void { pane.fs.unannounced = false; return; } + // A question still standing ends with it, so a follower of its `ask` + // hears the end. + if (pane.prompt == .repl_choice or pane.prompt == .del_side) { + var rec: [32]u8 = undefined; + notePath(p, "answer", std.fmt.bufPrint(&rec, "{d} -", .{pane.serial}) catch ""); + } noteLog(p, .del, pane); } diff --git a/src/pardes.zig b/src/pardes.zig index da9889ff..f55654b6 100644 --- a/src/pardes.zig +++ b/src/pardes.zig @@ -7096,6 +7096,17 @@ test "Del from a key asks which neighbour takes the rows; nothing else asks" { try std.testing.expectEqual(ctlfs.Status.ok, th.wr(p, ctl, "answer -\n").reply.status); try std.testing.expect(p.panes[asked] != null and p.panes[asked].?.prompt == .none); try std.testing.expect(th.logHas(p, try std.fmt.bufPrint(&want, "answer {d} -\n", .{serial}))); + // A pane closed while its question stands ends the question in the log. + p.newScratchBelow(top); + const closing = p.active; + p.sync(); + const closing_serial = p.panes[closing].?.serial; + p.update(.{ .key = .{ .cp = ' ' } }); + p.update(.{ .key = .{ .cp = 'd' } }); + try std.testing.expectEqual(Pane.Prompt.del_side, p.panes[closing].?.prompt); + try p.removePane(closing, null); + try std.testing.expect(th.logHas(p, try std.fmt.bufPrint(&want, "answer {d} -\ndel {d}", .{ closing_serial, closing_serial }))); + p.active = asked; p.update(.{ .key = .{ .cp = ' ' } }); p.update(.{ .key = .{ .cp = 'd' } }); try std.testing.expectEqual(ctlfs.Status.ok, th.wr(p, ctl, "answer k\n").reply.status); -- cgit v1.3