From 23c9932afe9bbf01aa84d780e9030dfb6e333475 Mon Sep 17 00:00:00 2001 From: Gabriel Schneider Date: Thu, 5 Nov 2026 13:28:13 -0300 Subject: effects out, the theme crossfade: a theme change takes the chrome at once, as it always took the content; colors.ChromeAnimation (its OKLab steps, its retarget, the ticks and the frames it asked of nextWake) goes, Pardes.chrome is the theme's chrome, set as the theme changes, and the `animate` flag goes from loadThemeFile and applyThemeEffect with it, as does the build's -Dtheme-animation option (and its place in the wire's fingerprint); no frontend fades a theme of its own (a window crossfading every cell's colour for 160 ms is a copy of the last frame kept and blended, for one keystroke's change); the fade's tests go, the PDF test loses its ticks through a fade, and `core animation keeps wall time at 60, 120 and 144 Hz and across a stall` goes with the one animation that ran it; the perf baselines lose the option from their build identity; GUI goldens 16-debug and 17-terminal change, the golden session having faded its themes by default: a fade's frames kept the Debug word's announcement up in the picture's pane, which gave up a row to it under the Debug box; the tree before this change built with -Dtheme-animation=false draws exactly these frames, all sixteen byte for byte Co-Authored-By: Claude Opus 5.5 Claude-Session: https://claude.ai/code/session_016Y9MNAtZenFv4weoMD3cge --- build.zig | 6 ------ 1 file changed, 6 deletions(-) (limited to 'build.zig') diff --git a/build.zig b/build.zig index 2a408bbf..f435a39f 100644 --- a/build.zig +++ b/build.zig @@ -40,7 +40,6 @@ const PerfBuild = struct { mupdf: bool, jpx: bool, tracy: bool, - theme_animation: bool, terminal_simd: bool, prebuilt_shaders: bool, }; @@ -265,7 +264,6 @@ pub fn build(b: *std.Build) void { if (target.result.os.tag == .freebsd or target.result.os.tag == .netbsd or target.result.os.tag == .openbsd) root_mod.linkSystemLibrary("util", .{}); - const theme_animation = b.option(bool, "theme-animation", "animate chrome colors across a theme change (default: on)") orelse true; // The macOS shell carries the workspace tag row's commands in its native // menu bar; the row itself goes away. `-Dworkspace-tag=true` puts it back. const workspace_tag = b.option(bool, "workspace-tag", "draw the workspace tag row (default: on except on macOS, whose menu bar carries its commands)"); @@ -283,7 +281,6 @@ pub fn build(b: *std.Build) void { .tree_sitter_grammars = tree_sitter_grammars, .tracy = tracy != null, .mupdf = enable_mupdf, - .theme_animation = theme_animation, .workspace_tag = workspace_tag, .prebuilt_shaders = prebuilt_shaders, .embed_sources = embed_sources, @@ -1341,7 +1338,6 @@ pub fn build(b: *std.Build) void { .mupdf = enable_mupdf, .jpx = enable_mupdf and enable_jpx, .tracy = tracy != null, - .theme_animation = theme_animation, .terminal_simd = ghostty_simd, .prebuilt_shaders = platform == .gui and prebuilt_shaders, }); @@ -1825,7 +1821,6 @@ const ShellConfig = struct { tree_sitter_grammars: TreeSitterGrammars, tracy: bool, mupdf: bool, - theme_animation: bool, /// null = "the platform's own default": the macOS shell hands the row to /// its native menu bar, every other shell keeps the acme topbar. workspace_tag: ?bool, @@ -1844,7 +1839,6 @@ fn shellOptions(b: *std.Build, cfg: ShellConfig, platform: Platform) *std.Build. o.addOption(bool, "enable_tracy", cfg.tracy); o.addOption(bool, "mupdf", cfg.mupdf); o.addOption(bool, "workspace_tag", cfg.workspace_tag orelse (platform != .macos)); - o.addOption(bool, "theme_animation", cfg.theme_animation); o.addOption(bool, "embed_sources", cfg.embed_sources); o.addOption([]const u8, "version", display_version); // ...and the commit it was built from, when there is one and the build -- cgit v1.3