From d1d5d3cfb18841604bba2057eeb3598f729b4475 Mon Sep 17 00:00:00 2001 From: Gabriel Schneider Date: Fri, 6 Nov 2026 02:56:53 -0300 Subject: client #1, the views indexed: a view's share of the session is Pardes.View (the ~42 fields views.fields named: size, cell metrics, columns, rects, focus, jumps, pointer, gestures, prefixes, frontend), one of Pardes.views[4] (null when closed), the live one views[live] through Pardes.view() (index field `view` renamed `live`); going into another view is the index plus the panes' shares, which stay swapped (park and unpark now move only Pane.pv); views.zig loses fields, Part over Pardes, Parked, kept, emptied and the session half of every copy, and a pane closing leaves every view's layout at once (views.gone, at the two places a slot is freed) instead of the serials each parked view kept; drawOne and within put the drawn view's own share back whole; the views are in the digest now (tape's per-field parts name views[k].field), so a fresh view's col_x/col_w default to zeros, not undefined; the dump keeps every open view in the core and the panes' shares of the others under `shares`; an image from before (live view as the core's own fields, the rest under `views`) loads them into views[] once; the ~2,400 references rewritten mechanically from the compiler's errors (p.active is p.view().active, `const v = p.view()` hoisted in 823 places), Kind.zig (4 lines) and addon_test.zig (3) among them, macos.zig by pattern (not compiled here); tape's watched host writes read the live view's frontend and active; perf.zig's accessor lines change its harness hash, the debug baselines re-keyed to it (their numbers the base's); no golden changes; gates: core-test 956/956 both, unit-test 1487/1488 tui and 1530/1531 gui, behaviour-test 248/248 both, pane-test 171/172, snap all 105 ok, process-test 0 of 37 failed tui, replicas ok Co-Authored-By: Claude Fable 5.1 Claude-Session: https://claude.ai/code/session_016Y9MNAtZenFv4weoMD3cge --- src/Places.zig | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) (limited to 'src/Places.zig') diff --git a/src/Places.zig b/src/Places.zig index 0ed64ae7..ddbbc271 100644 --- a/src/Places.zig +++ b/src/Places.zig @@ -604,9 +604,10 @@ pub fn step(set: *Places, p: *Pardes, pane: *Pane, forward: bool, count: u32, ad /// query's always; a search's while it is what the register says (an `s`, /// a `/` elsewhere or `"a` since makes them helix's register search again). pub fn answersN(set: *const Places, p: *Pardes, pane: *Pane) bool { + const v = p.view(); if (!set.shows(pane) and !set.started) return false; - if (set.provenance != .search) return p.register == 0; - const name = if (p.register != 0) p.register else p.registers.last_search; + if (set.provenance != .search) return v.register == 0; + const name = if (v.register != 0) v.register else p.registers.last_search; const pat = p.registers.value(name, 0) orelse return false; if (!set.literal) return std.mem.eql(u8, pat, set.pattern); var spelled: std.ArrayList(u8) = .empty; @@ -883,7 +884,7 @@ test "a session's places loaded from its dump find what an edit makes as the ses defer b.deinit(); try std.testing.expectEqual(pardes.walk.digest(Pardes, a), pardes.walk.digest(Pardes, b)); for ([_]*Pardes{ a, b }) |p| { - const pn = p.panes[p.active].?; + const pn = p.panes[p.view().active].?; const new = try gpa.dupe(u8, "alpha beta\ngamma alpha alpha\n"); File.setContentSpan(p, &pn.file.?, new, null); pn.places.fill(p, pn, 0, frame_steps); -- cgit v1.3