From 5be25178e4bfc2f390164e06697155cb0237babc Mon Sep 17 00:00:00 2001 From: Gabriel Schneider Date: Sun, 27 Sep 2026 22:24:43 -0300 Subject: Look no longer announces itself on the message row A look's answer is the pane it opens or the place it jumps to; its own name on the message row was only noise over that. Look now declares `pub const quiet = true;`, like Msg, so runBuiltin skips the announcement. A registry test checks that Look is quiet and Del still announces. 23 snapshot goldens drop the "Look" chip from the message row and nothing else: chordcut find hscroll images jumps layout-open look-center look-dir look-file look-file-1col lookloaded lsp lsp-client lspcomplete lsprelpath psearch stepgrain syntax tag tagbottomimage tagnav ttylook ttytaken. Updated with --update --jobs=1 on exactly those scripts; every changed row, compared screen by screen against the old golden, differs only by the blanked chip (and its style runs), and two full snap runs after the update pass. Co-Authored-By: Claude Opus 5.5 --- src/builtins.zig | 9 +++++++++ 1 file changed, 9 insertions(+) (limited to 'src/builtins.zig') diff --git a/src/builtins.zig b/src/builtins.zig index 87679f64..074d1328 100644 --- a/src/builtins.zig +++ b/src/builtins.zig @@ -169,6 +169,12 @@ test "capabilities exactly gate setting and effect-source builtins" { try std.testing.expectEqual(EffectCode.enabled, effect_code_registered); } +test "Look does not announce itself on the message row; Del still does" { + const Builtin = registry.Builtin(); + try std.testing.expect(!registry.announces(Builtin.Look)); + try std.testing.expect(registry.announces(Builtin.Del)); +} + test "Ligatures is a setting only in the shell that shapes text" { const exists = @hasField(registry.Builtin(), "Ligatures"); try std.testing.expectEqual(pardes.platform == .gui, exists); @@ -203,6 +209,9 @@ comptime { pub const Look = struct { pub const takes_arg = true; + // a look's answer is the pane it opens or the place it jumps to; its own + // name on the message row would only be noise over that + pub const quiet = true; pub fn run(c: Ctx) void { c.p.lookAt(c.id, c.arg orelse return); } -- cgit v1.3