From 23c9932afe9bbf01aa84d780e9030dfb6e333475 Mon Sep 17 00:00:00 2001 From: Gabriel Schneider Date: Thu, 5 Nov 2026 13:28:13 -0300 Subject: effects out, the theme crossfade: a theme change takes the chrome at once, as it always took the content; colors.ChromeAnimation (its OKLab steps, its retarget, the ticks and the frames it asked of nextWake) goes, Pardes.chrome is the theme's chrome, set as the theme changes, and the `animate` flag goes from loadThemeFile and applyThemeEffect with it, as does the build's -Dtheme-animation option (and its place in the wire's fingerprint); no frontend fades a theme of its own (a window crossfading every cell's colour for 160 ms is a copy of the last frame kept and blended, for one keystroke's change); the fade's tests go, the PDF test loses its ticks through a fade, and `core animation keeps wall time at 60, 120 and 144 Hz and across a stall` goes with the one animation that ran it; the perf baselines lose the option from their build identity; GUI goldens 16-debug and 17-terminal change, the golden session having faded its themes by default: a fade's frames kept the Debug word's announcement up in the picture's pane, which gave up a row to it under the Debug box; the tree before this change built with -Dtheme-animation=false draws exactly these frames, all sixteen byte for byte Co-Authored-By: Claude Opus 5.5 Claude-Session: https://claude.ai/code/session_016Y9MNAtZenFv4weoMD3cge --- src/draw.zig | 3 --- 1 file changed, 3 deletions(-) (limited to 'src/draw.zig') diff --git a/src/draw.zig b/src/draw.zig index 55fab141..9db5d0ff 100644 --- a/src/draw.zig +++ b/src/draw.zig @@ -1086,7 +1086,6 @@ test "an unfocused grip shows on its tag in the grid, in every native theme" { defer p.deinit(); _ = try p.setTestFile("text\n"); p.newScratchBelow(0); - p.animate_theme_changes = false; var arena: std.heap.ArenaAllocator = .init(std.testing.allocator); defer arena.deinit(); for (pardes.themes[0..colors.native_count], 0..) |theme, index| { @@ -1109,7 +1108,6 @@ test "a grip's four states, focused or not and clean or dirty, are each its own defer p.deinit(); const pane = try p.setTestFile("text\n"); p.newScratchBelow(0); - p.animate_theme_changes = false; var arena: std.heap.ArenaAllocator = .init(std.testing.allocator); defer arena.deinit(); const State = struct { first: Cell, second: Cell, dirty: bool }; @@ -1150,7 +1148,6 @@ test "every theme draws a file's name, a +Errors and a Term word in a tint, neve p.acknowledgeShell(terminal, "/bin/sh", false); try @import("Output.zig").openErrors(p, 0, try gpa.dupe(u8, "oops\n")); while (p.nextEffect()) |_| {} - p.animate_theme_changes = false; const errors = for (p.panes, 0..) |slot, id| { const pane = slot orelse continue; if (pane.file) |f| if (std.mem.endsWith(u8, f.path, "+Errors")) break id; -- cgit v1.3