From 34641e435fcbae0af578189760d5ebb05bc07f9a Mon Sep 17 00:00:00 2001 From: Gabriel Schneider Date: Tue, 17 Nov 2026 03:56:36 -0300 Subject: Term: a core without a terminal boots to a scratch pane, and a test skips only where it needs a terminal (docs/next-terminal.md, Phase 1, the no-terminal core): Pardes.init's shell boots (.shell, .classic, .tty, .tty_shell) are one scratch pane when Term.ops is null, so a test that booted a shell for convenience runs on it, where every one of them skipped before (Term.open refused with SkipZigTest under a test); Term.open refuses with error.NoTerminal, said by errorWords as Term.none, so Term and an exec no shell can take (a command pane) refuse in words (`Term: no terminal in this build`, `exec: ...`), and takesCommandLine is false with no terminal pane; a +Pager pages the bytes as they are (Term.page, unchanged); no boot message: the no-terminal core is a test build alone, read by no person, and a message at boot put seven core tests (the message log, the notice bands, the Del question's wake, a press on a column's rule) out of core-test; a test that fails for want of a terminal says so on its first line (`if (pardes.Term.ops == null) return error.SkipZigTest; // a shell`: a shell, a command pane, the classic boot's three shells, it reads the emulator, ...), 99 tests in 25 files, and ninep/testing.zig's withTerm, the fixture of 29 that assert a terminal pane, once; each attributed by its failure on the scratch boot (NoTerminal from newShell or newCommand, a shell's pane, prompt, pty bytes or tag asserted, the classic boot's panes indexed) and by reading its body; no assertion changes; test: Term.zig ends with the no-terminal core's three (each boot a scratch pane and no terminal; Term, newShell and an exec refused in words, no line typed at a shell; a program's output paged as plain text); core-test (no terminal) 411 passed / 535 skipped of 946 to 810 passed / 139 skipped of 949, shell-test 992: 989 passed, the three no-terminal tests skipped --- src/ninep/cols.zig | 4 ++++ 1 file changed, 4 insertions(+) (limited to 'src/ninep/cols.zig') diff --git a/src/ninep/cols.zig b/src/ninep/cols.zig index c8d84e5d..d953bcc7 100644 --- a/src/ninep/cols.zig +++ b/src/ninep/cols.zig @@ -435,6 +435,7 @@ test "Help and Find at /tagexec act in the session's directory, not the keyboard } test "a shell command at /tagexec or a column's exec is a command pane in the session's directory, never typed into the keyboard's terminal" { + if (pardes.Term.ops == null) return error.SkipZigTest; // a command pane const p = try Pardes.init(testing.allocator, .{ .tty_only = true, .cols = 80, .rows = 30 }); defer p.deinit(); while (p.nextEffect()) |_| {} @@ -455,6 +456,7 @@ test "a shell command at /tagexec or a column's exec is a command pane in the se } test "New and Term run at /tagexec and a column's exec, with no pane at all too" { + if (pardes.Term.ops == null) return error.SkipZigTest; // a shell const p = try th.withFile(testing.allocator, "x\n"); defer p.deinit(); const tagexec = @backingInt(tree.TopFile.tagexec); @@ -671,6 +673,7 @@ test "tagexec runs a word as a click in the workspace tag; exec files read back } test "a word run from the workspace's or a column's tag runs in the session's directory, a pane's in its own" { + if (pardes.Term.ops == null) return error.SkipZigTest; // a command pane const p = try th.withFile(testing.allocator, "x\n"); defer p.deinit(); const session = p.sessionDir(); @@ -689,6 +692,7 @@ test "a word run from the workspace's or a column's tag runs in the session's di } test "a command run from a column's tag gets its pane in that column, not the last" { + if (pardes.Term.ops == null) return error.SkipZigTest; // a command pane const p = try th.withFile(testing.allocator, "x\n"); defer p.deinit(); layout.newColumn(p, p.view().active); -- cgit v1.3