From 549cfa40e99c3d1937b742a0dba043281c687c83 Mon Sep 17 00:00:00 2001 From: Gabriel Schneider Date: Tue, 29 Sep 2026 12:29:43 -0300 Subject: A PDF's body reads the text layer of the page it shows The body of a PDF pane read as empty. It now reads MuPDF's text extraction of the page shown, the text search and n/N already use, read-only (a write is refused, as round 22's body refusal made it). Co-Authored-By: Claude Opus 5.5 --- src/ninep/pane.zig | 17 ++++++++++++++++- 1 file changed, 16 insertions(+), 1 deletion(-) (limited to 'src/ninep/pane.zig') diff --git a/src/ninep/pane.zig b/src/ninep/pane.zig index 9e832df6..311a2429 100644 --- a/src/ninep/pane.zig +++ b/src/ninep/pane.zig @@ -257,7 +257,7 @@ pub fn fileSize(p: *Pardes, id: usize, f: PaneFile) u64 { const pf = &pane.fs; return switch (f) { // A terminal's body reads its screen and history, as text. - .body => if (pane.file == null and pane.isTerminal()) panes.Terminal.screenTextLen(pane) else bodyOf(pane).len, + .body => if (pane.file == null and pane.isTerminal()) panes.Terminal.screenTextLen(pane) else if (pdfText(p, pane)) |t| t.len else bodyOf(pane).len, .data, .xdata => bodyOf(pane).len, .tag => tagOf(p, pane).len, .name => nameOf(pane).len + 1, @@ -367,6 +367,14 @@ fn readFlag(p: *Pardes, req: Req, on: bool) Reply { return tree.stagedReply(p, req); } +/// The text layer of the page a PDF pane shows (MuPDF's extraction, kept +/// with the page), null for any other pane. +fn pdfText(p: *Pardes, pane: *Pane) ?[]const u8 { + if (comptime !pardes.pdf_enabled) return null; + const pv = &(pane.pdf orelse return null); + return pv.ensureText(p.pdf_gpa); +} + fn readBody(p: *Pardes, req: Req, id: usize, pane: *Pane) Reply { if (pane.file != null) { const text = bodyOf(pane); @@ -379,6 +387,13 @@ fn readBody(p: *Pardes, req: Req, id: usize, pane: *Pane) Reply { .len = clip(n), } } }; } + // A PDF's body is its text layer, the page shown's: read-only. + if (pdfText(p, pane)) |text| { + const off = @min(req.off, text.len); + const out = p.fs.stage(p.gpa); + out.appendSlice(p.gpa, text[off..][0..@min(text.len - off, req.size)]) catch return Reply.fail(req.tag, E.NOMEM); + return tree.stagedReply(p, req); + } if (req.handle != 0 and pane.isTerminal()) return screen.readSnapshot(p, req, pane); const text = panes.Terminal.screenTextAlloc(pane, p.gpa) catch return Reply.fail(req.tag, E.NOMEM); -- cgit v1.3