From 342650183a54dcfcdce6ca4d45d6fdf48b2d1c1c Mon Sep 17 00:00:00 2001 From: Gabriel Schneider Date: Thu, 5 Nov 2026 23:16:22 -0300 Subject: settings #4, the three ways to place a search go, a query pane attached under the pane that asked, eight rows under its line 1 (Query.born_rows), the next search from that pane reusing it: SearchPlace, SearchPane and SearchRows, and with SearchPlace's column the finder column itself, src/Finder.zig and its reads (Core.zig's finder field, pardes.zig's export, views.zig's per-view and laid-out field names, panes.zig's emptied column, exec.placeNew's away column, and layout.zig's compute share, setColumnPairWidth, dropColumnUnannounced's heir and newColumn), with ctl's SearchRows check and the requiresArg and applySettingBuiltin arms; deleted tests: "SearchPlace column: query panes stack in a finder column at the right edge, nothing else moves after it opens, and it goes with its last pane" (Finder.zig) and the SearchPane new half of Query's "* seeds line 1" test; root_ctl's number refusal is Tab's range now; the guide says eight rows; a dump that kept the finder or the three fields loads without them; no golden changes; gates on tui: core-test 963/963, behaviour-test 241/241, unit-test 1479/1480, pane-test 171/172, snap all 105 scripts ok, process-test 0 of 37 failed; gui unit-test 1523/1524 Co-Authored-By: Claude Fable 5.1 Claude-Session: https://claude.ai/code/session_016Y9MNAtZenFv4weoMD3cge --- src/panes.zig | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) (limited to 'src/panes.zig') diff --git a/src/panes.zig b/src/panes.zig index 2e1e9262..c4a32413 100644 --- a/src/panes.zig +++ b/src/panes.zig @@ -1035,15 +1035,13 @@ pub fn removePane(p: *Pardes, id: usize, to: ?usize) error{OutOfMemory}!void { layout.removePane(p, id); p.panes[id] = null; if (kept) |k| p.store.close(p, k, gainer); - // The finder's last pane takes the column with it. - const finder_gone = if (emptied) |c| p.finder.emptied(p, c) else false; if (p.active != id) return; // No pane left: the session is over. p.active = gainer orelse beside orelse anyPane(p) orelse { p.quit = true; return p.emit(.quit); }; - if (emptied) |c| if (!finder_gone and p.header == null) tagline.enterHeader(p, c); + if (emptied) |c| if (p.header == null) tagline.enterHeader(p, c); } /// The pane Last should fall back to when the jumplist has nothing: the -- cgit v1.3