From c1917b949b9580de8bf0977874a210f0266812da Mon Sep 17 00:00:00 2001 From: Gabriel Schneider Date: Fri, 6 Nov 2026 06:24:42 -0300 Subject: kinds #14, the core's PDF code gone: pdf.zig and pdf_view.zig leave and every pdf_enabled branch with them; look, Jump, Recent, dumps (one from before the addon opens as its pane), the watch, mouse, keys, the rail and the tag go through Kind for any kind's pane; test/pdf.zig's behaviours are T1 cases over 9P (addons_pdf.zig) and pane cases (a Shadow over a replica, a file changed under it), the harnesses load pdf.so by path Co-Authored-By: Claude Fable 5.1 Claude-Session: https://claude.ai/code/session_016Y9MNAtZenFv4weoMD3cge --- src/walk.zig | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) (limited to 'src/walk.zig') diff --git a/src/walk.zig b/src/walk.zig index dc743a4d..d7ee63b3 100644 --- a/src/walk.zig +++ b/src/walk.zig @@ -1051,7 +1051,6 @@ const DecodeError = error{ EndOfDump, BadDump, Incompatible, OutOfMemory }; /// `image` holds with `allocs.image`. const Allocators = struct { image: ?std.mem.Allocator = null, - pdf: ?std.mem.Allocator = null, terminal: ?std.mem.Allocator = null, }; @@ -1281,8 +1280,8 @@ pub fn Load(comptime roots: []const type) type { out.* = .{ .raw = raw }; return; } - // A field this build compiles out (a PDF slot where there is no - // MuPDF): passed over, said only when it held something. + // A field this build compiles out (a void field): passed over, + // said only when it held something. if (comptime kindOf(Canon(T)) == .void) if (!l.same and l.src[ty].kind != .void) { const held = l.src[ty].kind != .optional or (l.at < l.bytes.len and l.bytes[l.at] != 0); try l.skip(ty); @@ -2378,8 +2377,8 @@ pub const Get = struct { if (comptime allocOf(T, field)) |which| if (@field(l.allocs, which)) |a| { l.gpa = a; }; - // A field this build compiles out (a PDF slot where there is no - // MuPDF): passed over, said when it held something. + // A field this build compiles out (a void field): passed over, + // said when it held something. if (comptime kindOf(Canon(F)) == .void) { if ((try slotOf(c)).tag != .none) l.note("{s}: not in this build", .{l.field}); return; -- cgit v1.3