From b4c7b2ff828d258dde78ff2dcded3b226e6d874d Mon Sep 17 00:00:00 2001 From: Gabriel Schneider Date: Thu, 29 Oct 2026 18:31:11 -0300 Subject: docs/next-daemon.md: phase 2 notes (the walker dump, crossing builds, load and revive, what the design missed); the GUI's Restore test keeps the dump's serial Co-Authored-By: Claude Opus 5.5 --- src/gui/gui.zig | 3 ++- src/walk.zig | 2 -- 2 files changed, 2 insertions(+), 3 deletions(-) (limited to 'src') diff --git a/src/gui/gui.zig b/src/gui/gui.zig index a342cfe2..c550aa4c 100644 --- a/src/gui/gui.zig +++ b/src/gui/gui.zig @@ -1109,7 +1109,8 @@ test "GUI PTY Restore joins a real reader waiting for queue space" { core.deinit(); core = replacement; shell.core = replacement; - try std.testing.expect(core.panes[0].?.serial != old_serial); + // The dump's pane, its serial too; its old shell stopped all the same. + try std.testing.expectEqual(old_serial, core.panes[0].?.serial); try std.testing.expectEqual(@as(usize, 0), queue.waiting); try std.testing.expect(queue.readers[0] == null); try std.testing.expectEqual(@as(c_int, -1), libc.fcntl(child.file.handle, libc.F.GETFD)); diff --git a/src/walk.zig b/src/walk.zig index 304fc5aa..00868133 100644 --- a/src/walk.zig +++ b/src/walk.zig @@ -659,7 +659,6 @@ pub fn Dump(comptime roots: []const type) type { out: std.Io.Writer.Allocating, memo: std.AutoHashMapUnmanaged(Key, u32) = .empty, shared: u32 = 0, - next_root: usize = 0, const Key = struct { addr: usize, len: usize, ty: u32 }; @@ -686,7 +685,6 @@ pub fn Dump(comptime roots: []const type) type { pub fn put(d: *Self, comptime T: type, v: *const T) !void { try writeU32(&d.out.writer, comptime indexIn(types, Canon(T))); try d.value(T, v); - d.next_root += 1; } /// Whether the pointer or slice at `addr` was met before: its -- cgit v1.3