From d31cc9eb97da97e3cb5268565ced3bf8c25f8540 Mon Sep 17 00:00:00 2001 From: Gabriel Schneider Date: Sun, 8 Nov 2026 20:45:42 -0300 Subject: fix: a raw terminal's key whose text passed forwardKey's 256-byte buffer (an input method's commit, a paste as one key) was dropped with no word: the encoding grows past the stack's room onto the heap and goes out through emitWrite, cut into writes in order; a failure to grow is reported; a pane test forwards 1000 bytes of key text and reads them back whole Co-Authored-By: Claude Fable 5.1 Claude-Session: https://claude.ai/code/session_016Y9MNAtZenFv4weoMD3cge --- src/terminal.zig | 15 ++++++++++----- 1 file changed, 10 insertions(+), 5 deletions(-) (limited to 'src') diff --git a/src/terminal.zig b/src/terminal.zig index 5338afa7..16ffb34b 100644 --- a/src/terminal.zig +++ b/src/terminal.zig @@ -1616,9 +1616,14 @@ pub fn forwardKey(p: *Pardes, id: usize, key: Key) void { utf8[0 .. std.unicode.utf8Encode(text_cp, &utf8) catch return] else ""; - var buffer: [256]u8 = undefined; - var writer = std.Io.Writer.fixed(&buffer); - input.encodeKey(&writer, .{ + // A key's text has no bound of its own (an input method's commit, a + // paste as one key): past the stack's room the encoding grows on the + // heap, and emitWrite cuts it into writes. + var room: [256]u8 = undefined; + var first: std.heap.BufferFirstAllocator = .init(&room, p.gpa); + var out: std.Io.Writer.Allocating = .init(first.allocator()); + defer out.deinit(); + input.encodeKey(&out.writer, .{ .key = physical, .mods = .{ .ctrl = key.ctrl, .alt = key.alt, .shift = key.shift }, .consumed_mods = .{ .shift = key.text.len > 0 and key.shift }, @@ -1637,8 +1642,8 @@ pub fn forwardKey(p: *Pardes, id: usize, key: Key) void { // the floor and forwards Alt-n to the child as a bare `n`. opts.macos_option_as_alt = .true; break :options opts; - }) catch return; - if (writer.end > 0) p.emit(.{ .write = .{ .pane = @intCast(id), .bytes = .from(writer.buffered()) } }); + }) catch |err| return p.reportError(id, "key", err); + if (out.written().len > 0) p.emitWrite(id, out.written()); } pub fn enterTty(p: *Pardes, id: usize) void { -- cgit v1.3