From e303492ced70ac4bab5d09b53eda633cbf9108df Mon Sep 17 00:00:00 2001 From: Gabriel Schneider Date: Sun, 8 Nov 2026 21:58:00 -0300 Subject: helix: zz and zc put the cursor's line (rows - 1) / 2 rows down the view, helix's align_view (helix-view/src/lib.rs:62-67), where pardes put it rows / 2 - 1 down, a row too high on an odd view: hxdiff's four gt-after-zz cases at 80x24 (21 body rows) pass, gb-after-zz passed only by the view's own missing row and now waits for it; a behaviour test centres l15 on the 21-row view Co-Authored-By: Claude Fable 5.1 Claude-Session: https://claude.ai/code/session_016Y9MNAtZenFv4weoMD3cge --- test/behaviour/keys.zig | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) (limited to 'test/behaviour') diff --git a/test/behaviour/keys.zig b/test/behaviour/keys.zig index 118681cd..e1f550e3 100644 --- a/test/behaviour/keys.zig +++ b/test/behaviour/keys.zig @@ -387,3 +387,19 @@ test "keys: a PDF in normal mode keeps : (its tag and back), SPC (a leader, canc try std.testing.expect(try s.cursor() == null); try std.testing.expectEqual(n, try s.focused()); } + +test "keys: zz and zc put the cursor's line in the middle row of an odd view, as many lines above it as below (helix align_view)" { + var lines: [30][4]u8 = undefined; + for (&lines, 0..) |*l, i| _ = try std.fmt.bufPrint(l, "l{d:0>2}\n", .{i}); + var s = try Session.initFile(std.testing.allocator, std.mem.asBytes(&lines)); + defer s.deinit(); + for ([_][]const u8{ "15jzz", "ztzc" }) |keys| { + try s.keys(keys); + // 80x24 gives the pane 21 rows: l05 to l25, l15 the eleventh + const top = (try s.where("l05"))[1]; + try std.testing.expectEqual(top + 10, (try s.where("l15"))[1]); + try std.testing.expectEqual(top + 20, (try s.where("l25"))[1]); + try std.testing.expectError(error.NotOnScreen, s.where("l04")); + try std.testing.expectError(error.NotOnScreen, s.where("l26")); + } +} -- cgit v1.3