From 7d359addc420eca66bd1583d8fd8d6a104986a03 Mon Sep 17 00:00:00 2001 From: Gabriel Schneider Date: Thu, 5 Nov 2026 00:31:38 -0300 Subject: panes: a pane's PDF state is its own allocation, `pdf: ?*Pdf.State` (made by openPane with pdf_gpa, freed by deinitPane), as a terminal's is, where every Pane held the State inline, a text file's and a terminal's too: a Pane is 49232 bytes where it was 88936 (the State 39704), and a replica's rollback copy of a pane without a PDF is that much smaller; the dump and the wire change with it, the walk writing the slot as a pointer to a State where it wrote the State in place, so a dump written before this, or a peer of an older build, gives its PDF panes no PDF (the walk notes `Pane.pdf: its kind changed; its default taken`, and dump.ensureKind makes each a terminal); the 97 uses change form only (a `|*x|` capture or a `&` dropped, normal.zig's one among them), applyNormal untouched Co-Authored-By: Claude Opus 5.5 Claude-Session: https://claude.ai/code/session_016Y9MNAtZenFv4weoMD3cge --- test/pdf_pointer_bench.zig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'test/pdf_pointer_bench.zig') diff --git a/test/pdf_pointer_bench.zig b/test/pdf_pointer_bench.zig index a6560263..573b8766 100644 --- a/test/pdf_pointer_bench.zig +++ b/test/pdf_pointer_bench.zig @@ -124,7 +124,7 @@ var verify_failures: usize = 0; fn verify(core: *pardes.Pardes, arena: std.mem.Allocator) !void { const Pdf = pardes.panes.Pdf; const pane = core.panes[0] orelse return; - const state = &(pane.pdf orelse return); + const state = pane.pdf orelse return; const highlights = try Pdf.buildHighlights(state, arena, Pdf.highlightInput(core, 0, pane)); for (state.rasters[0..state.rasters_len]) |*r| { if (!r.valid or r.rgba.len == 0 or r.tint_key == null) continue; -- cgit v1.3