From 7d359addc420eca66bd1583d8fd8d6a104986a03 Mon Sep 17 00:00:00 2001 From: Gabriel Schneider Date: Thu, 5 Nov 2026 00:31:38 -0300 Subject: panes: a pane's PDF state is its own allocation, `pdf: ?*Pdf.State` (made by openPane with pdf_gpa, freed by deinitPane), as a terminal's is, where every Pane held the State inline, a text file's and a terminal's too: a Pane is 49232 bytes where it was 88936 (the State 39704), and a replica's rollback copy of a pane without a PDF is that much smaller; the dump and the wire change with it, the walk writing the slot as a pointer to a State where it wrote the State in place, so a dump written before this, or a peer of an older build, gives its PDF panes no PDF (the walk notes `Pane.pdf: its kind changed; its default taken`, and dump.ensureKind makes each a terminal); the 97 uses change form only (a `|*x|` capture or a `&` dropped, normal.zig's one among them), applyNormal untouched Co-Authored-By: Claude Opus 5.5 Claude-Session: https://claude.ai/code/session_016Y9MNAtZenFv4weoMD3cge --- test/pdf_scroll_bench.zig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'test/pdf_scroll_bench.zig') diff --git a/test/pdf_scroll_bench.zig b/test/pdf_scroll_bench.zig index 391a98e6..1a27b828 100644 --- a/test/pdf_scroll_bench.zig +++ b/test/pdf_scroll_bench.zig @@ -263,7 +263,7 @@ fn probeTravel(config: Config) Travel { const first_frame_ns = nowNs() -| started; const pane = core.panes[0] orelse fatal("PDF pane disappeared", .{}); if (pane.pdf == null) fatal("{s} did not open as a PDF", .{path}); - const pv = &pane.pdf.?; + const pv = pane.pdf.?; if (!pv.layout_valid or pv.document_height == 0) fatal("the pixel strip never laid out; is native_images/cell_pixels wired?", .{}); // Exactly the clamp scrollPdfDocument enforces, so the last fling frame @@ -356,7 +356,7 @@ fn measure(config: Config, plan: Plan) !Result { _ = try core.render(frame_arena.allocator()); drainEffects(core); const pane = core.panes[0] orelse fatal("PDF pane disappeared", .{}); - const pv = &pane.pdf.?; + const pv = pane.pdf.?; const rect = core.rects[0]; // Anywhere inside the pane body resolves to this pane's hover, which // is what routes the notch; the exact cell is irrelevant to a wheel. -- cgit v1.3