From 42c0524b94d67caebbf71cd8a82d7690380195fa Mon Sep 17 00:00:00 2001 From: Gabriel Schneider Date: Mon, 27 Jul 2026 01:03:46 -0300 Subject: trim the taglines: image renderer toggles and Colors/Crt become leader-only MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The image tag spelled out `Petscii Ascii` and actOnSelection matched those words by hand before the builtin dispatch. They are three real Builtins now (SPC t p/l/a), so the by-word matching is gone, the tag is a plain `img Del`, and with nothing live left in it the image early-returns in curTail, enterTagEdit and the tag-click guard go too — an image tag edits like every other pane's. Colors and Crt leave the topbar for SPC t c / SPC t r: set-once display switches should not spend width in a bar you read every frame. NextColor stays, it is the one you cycle repeatedly. Both remain full builtins. The snap scripts that clicked those words now press the leader instead, and images.snap finally exercises the palette and ascii toggles for real: its old clicks at x=57 landed on the neighbouring shell's tag, so that toggle had never been covered. The test PPM grew to 512x512 with LCG noise so the ASCII bitmaps actually win cells and dropping them visibly changes the art. --- test/snapshots/images.snap | 32 ++++++++++++++++++++++++-------- 1 file changed, 24 insertions(+), 8 deletions(-) (limited to 'test/snapshots/images.snap') diff --git a/test/snapshots/images.snap b/test/snapshots/images.snap index e285d4bf..9c510bed 100644 --- a/test/snapshots/images.snap +++ b/test/snapshots/images.snap @@ -1,5 +1,7 @@ # image panes: right-click a .ppm opens petscii glyph art (no kitty in the -# harness); the live tag toggles palette (C64<->Term) and Ascii glyphs +# harness). The tag is an ordinary `img Del` — its renderer toggles are +# builtins now, pressed under SPC t (the old tag words sat past the pane's +# right edge, so clicking them only ever hit the neighbouring shell's tag). ppmdiag pic.ppm start 30 150 -n 3 wait 8000 pic.ppm @@ -17,13 +19,27 @@ wait 10000 img stable 700 20000 snap img-open snapstyle img-open -# toggle palette to terminal colors: middle-click the C64 word in the tag -press middle 57 2 -release middle 57 2 +# SPC t l: the C64 Pepto palette gives way to the terminal's own 16 (the cells +# stop carrying truecolor and carry ansi indices instead) +key space +key t +key l stable 700 15000 snapstyle term-palette -# toggle Ascii off -press middle 62 2 -release middle 62 2 +# SPC t a: drop the printable-ASCII bitmaps from the matcher's glyph set, so +# the art is blocks and sextants only. Captured as TEXT — this toggle changes +# which glyph each cell picks, which a style capture cannot see (the reason +# the old click-at-x=57 version of this step proved nothing even when it hit). +key space +key t +key a stable 700 15000 -snapstyle no-ascii +snap no-ascii +# the tag takes an edit like any other pane's now — nothing live left in it to +# protect, so the image early-return in enterTagEdit is gone +press left 20 2 +release left 20 2 +stable 400 5000 +text Zork +stable 400 5000 +snap tag-edit -- cgit v1.3