From 6877a61ef40ad0d8e762a28d0a3f5fa9bfefaff2 Mon Sep 17 00:00:00 2001 From: Gabriel Schneider Date: Mon, 27 Jul 2026 10:52:32 -0300 Subject: an output pane is not a document: +Search/+Help split below the pane that asked, never into a column of their own placeDoc classified any file pane as a doc, so a +Search opened from a lone shell took layoutInsertColumn(0) - a whole new leftmost column, shoving every existing column sideways - and an open results list was then eligible as the split parent for a real file, stacking documents under the list. An output buffer has no file behind it and no Save; it is the result list belonging to the pane that asked for it. Now it is that on both sides of the rule: it splits below from_id whatever kind of pane that is (a source that died falls back to stackDocLeft, the same last resort a full column bar uses), and it is skipped when a real doc hunts for its split parent, so a file opened from a search row joins the docs instead of the results. Real docs are untouched: fsearch/rsearch/look-file/tutor/lookpanes all pass unchanged. psearch is the proof - its results snap was two columns (the shell pushed to x=70, its gutter run at 70-71) and is now one 140-wide column with the +Search stacked below at the same x origin. --- test/snapshots/leader.golden | 32 ++++++++++++++++---------------- 1 file changed, 16 insertions(+), 16 deletions(-) (limited to 'test/snapshots/leader.golden') diff --git a/test/snapshots/leader.golden b/test/snapshots/leader.golden index 497f1e3d..7ad00456 100644 --- a/test/snapshots/leader.golden +++ b/test/snapshots/leader.golden @@ -244,7 +244,7 @@ | | | -== snap tutor grid=100x40 cursor=7,32 +== snap tutor grid=100x40 cursor=7,12 |Kill Newcol Tutor Debug NextColor Dump | NOR /tmp/pardes-snap/leader/cwd/cmds.txt Save De NOR /tmp/pardes-snap/leader/cwd Del | 1 Help @@ -256,6 +256,21 @@ | | | +| NOR /Tutor Save Del +| 1 +| 2 PARDES TUTOR +| 3 tmux + vi + acme, from +| 4 +| 5 The model is acme's: EVERYTHING is +| 6 the same way. Modal editing (helix- +| 7 Press j until you reach the introdu +| 8 +| 9 +| NOR /tmp/pardes-snap/leader/cwd/+Help Del +| 1 pardes builtins under SPC h +| 2 +| 3 SPC h t Tutor +| 4 | | | @@ -266,25 +281,10 @@ | | | -| NOR /tmp/pardes-snap/leader/cwd/+Help Del -| 1 pardes builtins under SPC h -| 2 -| 3 SPC h t Tutor -| 4 | | | | -| -| NOR /Tutor Save Del -| 1 -| 2 PARDES TUTOR -| 3 tmux + vi + acme, from -| 4 -| 5 The model is acme's: EVERYTHING is -| 6 the same way. Modal editing (helix- -| 7 Press j until you reach the introdu -| 8 == snap deleted grid=100x40 cursor=7,22 |Kill Newcol Tutor Debug NextColor Dump | NOR /tmp/pardes-snap/leader/cwd/cmds.txt Save De NOR /tmp/pardes-snap/leader/cwd Del -- cgit v1.3