summaryrefslogtreecommitdiff
path: root/9proc
diff options
context:
space:
mode:
authorGabriel Schneider <[email protected]>2026-11-17 13:04:05 -0300
committerGabriel Schneider <[email protected]>2026-11-17 13:06:13 -0300
commitf44744d8bfce2f94cae9a658c416a3c2a0364a6a (patch)
tree0a76dbc20b8fefa01c409bfb44dcfdee27dab463 /9proc
parent9dd6f001c7d5eee987cbd305a79d1b1d011b83f5 (diff)
downloadcloud9-f44744d8bfce2f94cae9a658c416a3c2a0364a6a.tar.gz
cloud9-f44744d8bfce2f94cae9a658c416a3c2a0364a6a.zip
build: a library's part for a consumer, and no more
A package that depends on cloud9 ran all of its build(): the tests, 9web, the probes and the three program fragments, with the jj and the date 9proc's fragment spawns at configure, and it had to pass .target and .optimize, since the module carried both (one forgotten, cloud9 was Debug inside a release build). Now build() exports two modules with no target or optimize of their own, which take their importer's (std.Build.Module's CreateOptions: unspecified options are inherited): cloud9, and 9proc beside it at the top level, then returns when it is not the root (b.isRoot()). A consumer writes b.dependency("cloud9", .{}).module("cloud9"). The root's tests and programs root a compilation on the library, which needs a target, so they make their own module from the same file: the five lines the module took before, now a createModule, and 9proc's fragment makes its copy with createModule where it exported with addModule (no line more). The target and optimize options are still declared before the return: pardes and sketchbook pass both today, and an undeclared option a dependency is given is logged as "invalid option" (target, cpu and optimize) with a stack trace on every configure of theirs (not fatal: Build.dependencyResolved reports it, only the root's invalid options exit, compiler/configurer.zig:146-158; seen in a consumer: rc 0, three errors). The comment says to move both under the return once they pass nothing. zig build test 106 of 108 at load 15 (serve's "a ticket of a hung-up client" and "repeated connect/disconnect", the two known to fail under load; see the next change for quiet runs); install into a scratch prefix builds 9web, 9ns, 9agents, 9proc-demo and cloud9-probe as before. Co-Authored-By: Claude Opus 5.5 <[email protected]> Claude-Session: https://claude.ai/code/session_016Y9MNBECMWcJD5pdS4SR6T
Diffstat (limited to '9proc')
-rw-r--r--9proc/build.zig10
1 files changed, 5 insertions, 5 deletions
diff --git a/9proc/build.zig b/9proc/build.zig
index 43176d7..cf32886 100644
--- a/9proc/build.zig
+++ b/9proc/build.zig
@@ -21,9 +21,8 @@ pub const Context = struct {
};
pub const Artifacts = struct {
- /// The `9proc` module, exported with `b.addModule` so dependents of
- /// cloud9 can `.module("9proc")`. Built for any target; the Linux
- /// layer is compiled in only when the target OS is Linux.
+ /// The `9proc` module for `target`: the Linux layer is compiled in
+ /// only when the target OS is Linux.
module: *std.Build.Module,
/// The demo 9P2000 server (binary `9proc-demo`); null when the target is
/// not Linux. 9ns's integration tests use it as their server.
@@ -59,8 +58,9 @@ pub fn add(b: *std.Build, ctx: Context) Artifacts {
build_options.addOption([]const u8, "target", target.result.zigTriple(b.allocator) catch "unknown");
// The library: freestanding core + vars, scratch (allocator), Linux layer.
- // Exported under the name `9proc` for packages that depend on cloud9.
- const lib_mod = b.addModule("9proc", .{
+ // This copy is for `target`; packages that depend on cloud9 get the one
+ // the root exports, which has no target of its own.
+ const lib_mod = b.createModule(.{
.root_source_file = b.path("9proc/src/root.zig"),
.target = target,
.optimize = optimize,