summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorGabriel Schneider <[email protected]>2026-11-10 12:06:09 -0300
committerGabriel Schneider <[email protected]>2026-11-10 12:09:34 -0300
commit08d36ff6295a5f04e503ffe0aaa8a4e712af865f (patch)
treeb4844874ce6c7f6c91ef82762bb342193f1fc67a
parent2be93397533432020413d6e0bb5021e2f565ef9c (diff)
downloadcomputeranim-08d36ff6295a5f04e503ffe0aaa8a4e712af865f.tar.gz
computeranim-08d36ff6295a5f04e503ffe0aaa8a4e712af865f.zip
ring: a producer waiting for room is woken at half empty, not at every record
A full ring made consumer and producer trade a futex wake for every record: 2.8 M events/s through ztrace run where the recorder alone does 12 M. One comparison in advance. Co-Authored-By: Claude Fable 5.2 <[email protected]>
-rw-r--r--src/trace/Ring.zig7
1 files changed, 5 insertions, 2 deletions
diff --git a/src/trace/Ring.zig b/src/trace/Ring.zig
index 766ed63..0bde33a 100644
--- a/src/trace/Ring.zig
+++ b/src/trace/Ring.zig
@@ -196,8 +196,11 @@ pub fn advance(r: *Ring, rec: Record) void {
const size = record_overhead + std.mem.alignForward(usize, rec.payload.len, 8);
const start: [*]u8 = @ptrFromInt(@intFromPtr(rec.ev) - 8);
@memset(start[0..size], 0);
- _ = h.tail.fetchAdd(size, .seq_cst);
- if (h.space_waiters.load(.seq_cst) != 0) {
+ const tail = h.tail.fetchAdd(size, .seq_cst) + size;
+ // A producer waiting for room is woken once half the ring is free, not
+ // at every record: the wake is a syscall, and it would be back waiting
+ // a record later.
+ if (h.space_waiters.load(.seq_cst) != 0 and h.head.load(.acquire) - tail <= h.capacity / 2) {
_ = h.space_seq.fetchAdd(1, .release);
futexWake(&h.space_seq);
}