summaryrefslogtreecommitdiff
path: root/src/builtins.zig
diff options
context:
space:
mode:
authorGabriel Schneider <[email protected]>2026-10-23 11:00:44 -0300
committerGabriel Schneider <[email protected]>2026-10-23 17:10:58 -0300
commit80314064f6e81c8828340e010202b446f0e1f36d (patch)
treeaa56e86238ac9397055f601db924868bb6511538 /src/builtins.zig
parenta53a1aafb9804e943bdcd720c2bb688ecb90a888 (diff)
downloadpardes-80314064f6e81c8828340e010202b446f0e1f36d.tar.gz
pardes-80314064f6e81c8828340e010202b446f0e1f36d.zip
Audit (misc): std mkdir -p and JSON escaping, a 9P late failure's errno from ctl.failureErrno, dead switches and dumpHex out
Co-Authored-By: Claude Opus 5.5 <[email protected]>
Diffstat (limited to 'src/builtins.zig')
-rw-r--r--src/builtins.zig86
1 files changed, 26 insertions, 60 deletions
diff --git a/src/builtins.zig b/src/builtins.zig
index 7b1541ac..64710554 100644
--- a/src/builtins.zig
+++ b/src/builtins.zig
@@ -109,54 +109,27 @@ pub fn absentWhy(name: []const u8) ?[]const u8 {
return null;
}
-fn manualBuiltinCount() comptime_int {
+fn manualBuiltinList() []const type {
comptime {
- var count = 0;
+ @setEvalBranchQuota(4000);
+ var list: []const type = &.{};
for (@typeInfo(@This()).@"struct".decl_names) |d| {
if (@TypeOf(@field(@This(), d)) != type) continue;
const T = @field(@This(), d);
if (@typeInfo(T) != .@"struct" or !@hasDecl(T, "run") or !isEnabled(T)) continue;
if (@TypeOf(T.run) != fn (Ctx) void)
@compileError(d ++ ".run must have signature fn (Ctx) void");
- count += 1;
- }
- return count;
- }
-}
-
-fn manualBuiltinList() [manualBuiltinCount()]type {
- comptime {
- @setEvalBranchQuota(4000);
- var list: [manualBuiltinCount()]type = undefined;
- var count = 0;
- for (@typeInfo(@This()).@"struct".decl_names) |d| {
- if (@TypeOf(@field(@This(), d)) != type) continue;
- const T = @field(@This(), d);
- if (@typeInfo(T) != .@"struct" or !@hasDecl(T, "run") or !isEnabled(T)) continue;
- list[count] = T;
- count += 1;
+ list = list ++ .{T};
}
return list;
}
}
-fn settingCount() comptime_int {
+fn settingList() []const config.Runtime.Setting {
comptime {
- var count = 0;
+ var list: []const config.Runtime.Setting = &.{};
for (config.Runtime.settings) |setting| if (setting.enabled(capabilities)) {
- count += 1;
- };
- return count;
- }
-}
-
-fn settingList() [settingCount()]config.Runtime.Setting {
- comptime {
- var list: [settingCount()]config.Runtime.Setting = undefined;
- var count = 0;
- for (config.Runtime.settings) |setting| if (setting.enabled(capabilities)) {
- list[count] = setting;
- count += 1;
+ list = list ++ .{setting};
};
return list;
}
@@ -197,11 +170,17 @@ pub const registry = struct {
return @Enum(Tag, .exhaustive, &names, &std.simd.iota(Tag, count));
}
+ /// What a hand-written builtin says as `name` (`pub const takes_arg =
+ /// true;`), `default` when it says nothing, and `setting` for a setting.
+ fn declOr(b: Builtin(), comptime name: []const u8, default: anytype, setting: @TypeOf(default)) @TypeOf(default) {
+ inline for (comptime manualBuiltinList(), 0..) |T, i|
+ if (@backingInt(b) == i) return if (@hasDecl(T, name)) @field(T, name) else default;
+ return setting;
+ }
+
pub fn takesArg(b: Builtin()) bool {
- inline for (manualBuiltinList(), 0..) |T, i|
- if (@backingInt(b) == i) return @hasDecl(T, "takes_arg") and T.takes_arg;
// Every setting takes its value, and a switch flips when bare.
- return true;
+ return declOr(b, "takes_arg", false, true);
}
/// Whether the word takes its argument joined by a `+` as one word a
@@ -209,9 +188,7 @@ pub const registry = struct {
/// that says `pub const plus_arg = true;`: others have arguments a `+`
/// may be in (`Dump+2024.zon` is a name, not Dump's argument).
pub fn plusArg(b: Builtin()) bool {
- inline for (manualBuiltinList(), 0..) |T, i|
- if (@backingInt(b) == i) return @hasDecl(T, "plus_arg") and T.plus_arg;
- return false;
+ return declOr(b, "plus_arg", false, false);
}
/// Whether the word means nothing without its argument (`Mount`,
@@ -222,15 +199,11 @@ pub const registry = struct {
/// it says `pub const needs: PaneKind = .terminal;`, and on any other
/// pane it is refused (exec.runBuiltinFrom), as Repl and Edit are.
pub fn needs(b: Builtin()) ?PaneKind {
- inline for (manualBuiltinList(), 0..) |T, i|
- if (@backingInt(b) == i) return if (@hasDecl(T, "needs")) T.needs else null;
- return null;
+ return declOr(b, "needs", @as(?PaneKind, null), null);
}
pub fn requiresArg(b: Builtin()) bool {
- inline for (manualBuiltinList(), 0..) |T, i|
- if (@backingInt(b) == i) return @hasDecl(T, "requires_arg") and T.requires_arg;
- inline for (comptime settingList(), manualBuiltinCount()..) |setting, i|
+ inline for (comptime settingList(), comptime manualBuiltinList().len..) |setting, i|
if (@backingInt(b) == i) return switch (setting.action) {
// a switch flips bare, a choice steps, and DumpDir and Shell bare
// are the default
@@ -239,35 +212,28 @@ pub const registry = struct {
// bare, it says the current value (exec.applySettingBuiltin)
.tab, .callstack_depth => false,
};
- unreachable;
+ return declOr(b, "requires_arg", false, false);
}
pub fn scope(b: Builtin()) Scope {
- inline for (manualBuiltinList(), 0..) |T, i|
- if (@backingInt(b) == i) return if (@hasDecl(T, "scope")) T.scope else .pane;
- return .session; // a setting
+ return declOr(b, "scope", Scope.pane, .session);
}
pub fn outputTraits(b: Builtin()) ?OutputTraits {
- inline for (manualBuiltinList(), 0..) |T, i|
- if (@backingInt(b) == i) return if (@hasDecl(T, "output")) T.output else null;
- inline for (comptime settingList(), manualBuiltinCount()..) |_, i|
- if (@backingInt(b) == i) return null;
- unreachable;
+ return declOr(b, "output", @as(?OutputTraits, null), null);
}
/// Does this builtin say its own name on the message row before it runs?
/// The ones that own that row themselves declare `quiet` and do not.
pub fn announces(b: Builtin()) bool {
- inline for (manualBuiltinList(), 0..) |T, i|
- if (@backingInt(b) == i) return !(@hasDecl(T, "quiet") and T.quiet);
- return true; // a setting builtin changes something invisible; say so
+ // a setting builtin changes something invisible; say so
+ return !declOr(b, "quiet", false, false);
}
pub fn dispatch(b: Builtin(), c: Ctx) void {
- inline for (manualBuiltinList(), 0..) |T, i|
+ inline for (comptime manualBuiltinList(), 0..) |T, i|
if (@backingInt(b) == i) return T.run(c);
- inline for (comptime settingList(), manualBuiltinCount()..) |setting, i|
+ inline for (comptime settingList(), comptime manualBuiltinList().len..) |setting, i|
if (@backingInt(b) == i) return exec.applySettingBuiltin(c.p, setting, c.arg);
unreachable;
}