Ripple and Glitch are gone; Crt stays

The user tried them live and wants them removed entirely: the builtins,
their levels, config keys and leader paths (tR, tg), their slots in the
built-in chain, their shaders (source and prebuilt), EffectCode paths, and
on macOS their scene flags (pardes.h), the Metal kernel's coordinate warps
and the Swift pointer mapping that mirrored them. Docs say so (decision 8
in docs/render-pipeline.md); config.md documents Crt's levels, Shader and
ShaderAnimation instead.

Shared files touched: macos.zig (flags). Not touched: pardes.zig,
Messages.zig, mouse.zig, gui.zig, detached/*.

1 files changed, 7 insertions, 15 deletions

diff --git a/src/config.zig b/src/config.zig
index e8c5a705..d1e5f23d 100644
--- a/src/config.zig
+++ b/src/config.zig
@@ -129,8 +129,6 @@ pub const leader_path = paths: {
     }
     if (builtins.capabilities.scene_shaders) {
         table.set(.Crt, "tr");
-        table.set(.Ripple, "tR");
-        table.set(.Glitch, "tg");
         table.set(.Shader, null);
         table.set(.ShaderAnimation, null);
     }
@@ -622,7 +620,7 @@ pub const Runtime = struct {
 
     pub const ShaderAnimation = enum { off, on, always };
 
-    /// Each pass a bundled effect (Crt, Ripple, Glitch) or a Shadertoy file.
+    /// Each pass the bundled Crt or a Shadertoy file.
     pub const Post = struct {
         pub const max = 8;
         pub const Entry = struct {
@@ -774,8 +772,8 @@ pub const Runtime = struct {
     pub const MessageTime = enum { linger, fall, dissolve };
 
     pub const Toggle = enum { colors, wrap, tree_context_tag_style, tag_bottom, debug, focus_tint, column_tags, syntax_bold, verbose, message_animation, ligatures };
-    /// The bundled post passes, each a Shadertoy file in shaders/post/.
-    pub const Scene = enum { crt, ripple, glitch };
+    /// The bundled post pass, a Shadertoy file in shaders/post/.
+    pub const Scene = enum { crt };
 
     pub const Action = union(enum) {
         toggle: Toggle,
@@ -843,8 +841,6 @@ pub const Runtime = struct {
         .{ .word = "PanelScramble", .action = .{ .transition = .scramble }, .availability = .panel_transitions },
         .{ .word = "PanelType", .action = .{ .transition = .typewriter }, .availability = .panel_transitions },
         .{ .word = "Crt", .action = .{ .scene = .crt }, .availability = .scene_shaders },
-        .{ .word = "Ripple", .action = .{ .scene = .ripple }, .availability = .scene_shaders },
-        .{ .word = "Glitch", .action = .{ .scene = .glitch }, .availability = .scene_shaders },
         .{ .word = "Shader", .action = .shader, .availability = .scene_shaders },
         .{ .word = "ShaderAnimation", .action = .shader_animation, .availability = .scene_shaders },
     };
@@ -1263,18 +1259,18 @@ pub const Runtime = struct {
     test "the post chain runs in the order its passes were put in, and Shader off empties it of files" {
         var state: Runtime = .{};
         try std.testing.expect(apply(&state, find("Shader").?, " ~/a.glsl\n"));
-        try std.testing.expect(apply(&state, find("Glitch").?, "on"));
+        try std.testing.expect(apply(&state, find("Crt").?, "on"));
         try std.testing.expect(apply(&state, find("Shader").?, "/b.glsl"));
         const chain = state.post.list();
         try std.testing.expectEqual(@as(usize, 3), chain.len);
         try std.testing.expectEqualStrings("~/a.glsl", chain[0].path.get());
-        try std.testing.expectEqual(Scene.glitch, chain[1].scene.?);
+        try std.testing.expectEqual(Scene.crt, chain[1].scene.?);
         try std.testing.expectEqualStrings("/b.glsl", chain[2].path.get());
         const moved = state.post.generation;
         // A file named again leaves; the others keep their order.
         try std.testing.expect(apply(&state, find("Shader").?, "~/a.glsl"));
         try std.testing.expect(state.post.generation != moved);
-        try std.testing.expectEqual(Scene.glitch, state.post.list()[0].scene.?);
+        try std.testing.expectEqual(Scene.crt, state.post.list()[0].scene.?);
         try std.testing.expect(apply(&state, find("Shader").?, "off"));
         try std.testing.expectEqual(@as(usize, 1), state.post.len);
         try std.testing.expect(!apply(&state, find("Shader").?, null));
@@ -1288,7 +1284,7 @@ pub const Runtime = struct {
         const crt = find("Crt").?;
         try std.testing.expect(apply(&state, crt, "on"));
         try std.testing.expectEqual(@as(u8, Post.default_level), state.post.level(.crt));
-        try std.testing.expect(apply(&state, find("Glitch").?, "1"));
+        try std.testing.expect(apply(&state, find("Shader").?, "/after.glsl"));
         const moved = state.post.generation;
         try std.testing.expect(apply(&state, crt, "3"));
         try std.testing.expectEqual(@as(u8, 3), state.post.level(.crt));
@@ -1472,8 +1468,6 @@ pub const Runtime = struct {
                 },
                 .scene => |effect| switch (effect) {
                     .crt => "Crt 2\n",
-                    .ripple => "Ripple 2\n",
-                    .glitch => "Glitch 2\n",
                 },
                 .shader => "Shader ~/crt.glsl\n",
                 .shader_animation => "ShaderAnimation always\n",
@@ -1544,8 +1538,6 @@ pub const Runtime = struct {
         try std.testing.expect(std.mem.indexOf(u8, defaults_report, "Font requested") == null);
         try std.testing.expect(std.mem.indexOf(u8, defaults_report, "Panel transition off\n") != null);
         try std.testing.expect(std.mem.indexOf(u8, defaults_report, "Crt unsupported\n") != null);
-        try std.testing.expect(std.mem.indexOf(u8, defaults_report, "Ripple unsupported\n") != null);
-        try std.testing.expect(std.mem.indexOf(u8, defaults_report, "Glitch unsupported\n") != null);
         try std.testing.expect(std.mem.indexOf(u8, defaults_report, "TaglineSize unsupported\n") != null);
         try std.testing.expect(std.mem.indexOf(u8, defaults_report, "Look hover delay: off\n") != null);
         try std.testing.expect(std.mem.indexOf(u8, defaults_report, "Native images: off\n") != null);