diff options
| author | Gabriel Schneider <[email protected]> | 2026-11-05 23:16:22 -0300 |
|---|---|---|
| committer | Gabriel Schneider <[email protected]> | 2026-11-05 23:58:31 -0300 |
| commit | 342650183a54dcfcdce6ca4d45d6fdf48b2d1c1c (patch) | |
| tree | 1ea95aa777d8ee643cfdaa8c188a8cb8ad1f27c5 /src/exec.zig | |
| parent | 3ebdbe26a14546f8e4ee06462850aad85f1c9646 (diff) | |
| download | pardes-342650183a54dcfcdce6ca4d45d6fdf48b2d1c1c.tar.gz pardes-342650183a54dcfcdce6ca4d45d6fdf48b2d1c1c.zip | |
settings #4, the three ways to place a search go, a query pane attached under the pane that asked, eight rows under its line 1 (Query.born_rows), the next search from that pane reusing it: SearchPlace, SearchPane and SearchRows, and with SearchPlace's column the finder column itself, src/Finder.zig and its reads (Core.zig's finder field, pardes.zig's export, views.zig's per-view and laid-out field names, panes.zig's emptied column, exec.placeNew's away column, and layout.zig's compute share, setColumnPairWidth, dropColumnUnannounced's heir and newColumn), with ctl's SearchRows check and the requiresArg and applySettingBuiltin arms; deleted tests: "SearchPlace column: query panes stack in a finder column at the right edge, nothing else moves after it opens, and it goes with its last pane" (Finder.zig) and the SearchPane new half of Query's "* seeds line 1" test; root_ctl's number refusal is Tab's range now; the guide says eight rows; a dump that kept the finder or the three fields loads without them; no golden changes; gates on tui: core-test 963/963, behaviour-test 241/241, unit-test 1479/1480, pane-test 171/172, snap all 105 scripts ok, process-test 0 of 37 failed; gui unit-test 1523/1524
Co-Authored-By: Claude Fable 5.1 <[email protected]>
Claude-Session: https://claude.ai/code/session_016Y9MNAtZenFv4weoMD3cge
Diffstat (limited to 'src/exec.zig')
| -rw-r--r-- | src/exec.zig | 17 |
1 files changed, 4 insertions, 13 deletions
diff --git a/src/exec.zig b/src/exec.zig index aaca3e0e..ca79a481 100644 --- a/src/exec.zig +++ b/src/exec.zig @@ -1054,7 +1054,7 @@ pub fn applySettingBuiltin(p: *Pardes, setting: config.Runtime.Setting, arg: ?[] if (!p.settings.apply(setting, want)) p.reportFailure(p.active, "Shell: takes " ++ comptime config.Runtime.takes(.shell).?); }, // Bare, each says its value, as acme's Tab says the width. - inline .tab, .callstack_depth, .search_rows => |_, tag| if (arg == null) { + inline .tab, .callstack_depth => |_, tag| if (arg == null) { var said: [40]u8 = undefined; return p.setMessage(p.active, std.fmt.bufPrint(&said, "{s} {d}", .{ setting.word, @field(p.settings, @tagName(tag)) }) catch setting.word); } else if (!p.settings.apply(setting, arg)) { @@ -1095,14 +1095,6 @@ pub fn placeNew(p: *Pardes, from: usize, origin: ?usize, id: usize, kind: NewPan // No column left (the last one Delcol'd): a pane made from the workspace // tag opens one to go in. _ = layout.firstColumn(p); - // Anything asked from the finder column (a row looked at, a command - // there) goes where its query came from, never into the finder; and - // the rules that take the last column take the last that is not it. - const exec_column = p.exec_column; - defer p.exec_column = exec_column; - const away = p.finder.away(p, from, kind); - if (away) |c| p.exec_column = c; - const finder_column = p.finder.column(p); const asked = if (p.exec_column != null) null else origin; layout.compute(p); const before = p.rects; @@ -1112,10 +1104,9 @@ pub fn placeNew(p: *Pardes, from: usize, origin: ?usize, id: usize, kind: NewPan // (look.c:921-923, et->col). .scratch => layout.acmePlace(p, p.exec_column orelse columnOf(p, from), null, id), // +Errors, a command's output: the last column (util.c:94-98); a - // command run from a column's tag, that column. The finder's is - // never the last column for them. + // command run from a column's tag, that column. .command => layout.acmePlace(p, p.exec_column orelse p.ncol - 1, null, id), - .errors => layout.acmePlace(p, away orelse p.ncol - 1, null, id), + .errors => layout.acmePlace(p, p.ncol - 1, null, id), // makenewwindow(nil) for 9P's new (acme.c:877), else (t). .fs => layout.acmePlace(p, acmeColumn(p, from), null, id), .shell, .doc => layout.acmePlace(p, acmeColumn(p, from), asked, id), @@ -1148,7 +1139,7 @@ pub fn placeNew(p: *Pardes, from: usize, origin: ?usize, id: usize, kind: NewPan var c = p.ncol; while (c > 0) { c -= 1; - if (c == f.col or c == finder_column) continue; + if (c == f.col) continue; for (p.cols[c].panes[0..p.cols[c].n]) |k| p.rects[k] = before[k]; layout.snapColWeights(p, c); if (p.cols[c].n == 0) { |
