summaryrefslogtreecommitdiff
path: root/src/locations.zig
diff options
context:
space:
mode:
authorGabriel Schneider <[email protected]>2026-10-23 11:00:44 -0300
committerGabriel Schneider <[email protected]>2026-10-23 17:10:58 -0300
commit80314064f6e81c8828340e010202b446f0e1f36d (patch)
treeaa56e86238ac9397055f601db924868bb6511538 /src/locations.zig
parenta53a1aafb9804e943bdcd720c2bb688ecb90a888 (diff)
downloadpardes-80314064f6e81c8828340e010202b446f0e1f36d.tar.gz
pardes-80314064f6e81c8828340e010202b446f0e1f36d.zip
Audit (misc): std mkdir -p and JSON escaping, a 9P late failure's errno from ctl.failureErrno, dead switches and dumpHex out
Co-Authored-By: Claude Opus 5.5 <[email protected]>
Diffstat (limited to 'src/locations.zig')
-rw-r--r--src/locations.zig25
1 files changed, 11 insertions, 14 deletions
diff --git a/src/locations.zig b/src/locations.zig
index 1e4a20cf..6f086214 100644
--- a/src/locations.zig
+++ b/src/locations.zig
@@ -33,6 +33,15 @@ pub fn freeRows(gpa: std.mem.Allocator, rows: []Row) void {
gpa.free(rows);
}
+/// A list of rows being built, given up: each row's own bytes, then the list.
+pub fn freeRowList(gpa: std.mem.Allocator, rows: *std.ArrayList(Row)) void {
+ for (rows.items) |row| {
+ gpa.free(row.path);
+ gpa.free(row.colors);
+ }
+ rows.deinit(gpa);
+}
+
pub fn equalRows(a: []const Row, b: []const Row) bool {
if (a.len != b.len) return false;
for (a, b) |left, right| {
@@ -316,13 +325,7 @@ pub fn formatCallstack(p: *pardes.Pardes, dir: []const u8, input: []const u8) !R
var out: std.Io.Writer.Allocating = .init(p.gpa);
errdefer out.deinit();
var rows: std.ArrayList(Row) = .empty;
- errdefer {
- for (rows.items) |row| {
- p.gpa.free(row.path);
- p.gpa.free(row.colors);
- }
- rows.deinit(p.gpa);
- }
+ errdefer freeRowList(p.gpa, &rows);
const stacked = p.settings.callstack_layout == .stacked;
const resolved = try resolveCallstack(p, arena, dir, input);
var lines = std.mem.splitScalar(u8, std.mem.trimEnd(u8, input, "\n"), '\n');
@@ -496,13 +499,7 @@ pub fn format(p: *pardes.Pardes, dir: []const u8, input: []const u8, anchor: ?us
var out: std.Io.Writer.Allocating = .init(p.gpa);
errdefer out.deinit();
var rows: std.ArrayList(Row) = .empty;
- errdefer {
- for (rows.items) |row| {
- p.gpa.free(row.path);
- p.gpa.free(row.colors);
- }
- rows.deinit(p.gpa);
- }
+ errdefer freeRowList(p.gpa, &rows);
var mapped = anchor;
if (p.locations_config.layout == .stacked) {
for (pending.items, 0..) |row, index| {