summaryrefslogtreecommitdiff
path: root/src/look.zig
diff options
context:
space:
mode:
authorGabriel Schneider <[email protected]>2026-11-04 23:27:59 -0300
committerGabriel Schneider <[email protected]>2026-11-04 23:35:18 -0300
commit383256a741117596931c4e3817491041fde5229d (patch)
treeaf2ae2e868c8b514a12598c4ac7b5cd0fe2fc6f7 /src/look.zig
parent3b790a525c964f5b1dd4c1296c8291b7ecc3da22 (diff)
downloadpardes-383256a741117596931c4e3817491041fde5229d.tar.gz
pardes-383256a741117596931c4e3817491041fde5229d.zip
config: look_preview_delay_frames is a u16, as its ?u16 was never null: every orelse return after it, look.zig's discarded delay, and the report's never-written Look hover delay: off line go, the tests passing the constant (pardes.zig, ninep/tree.zig and ctl.zig's test take one line each)
Co-Authored-By: Claude Opus 5.5 <[email protected]> Claude-Session: https://claude.ai/code/session_016Y9MNAtZenFv4weoMD3cge
Diffstat (limited to 'src/look.zig')
-rw-r--r--src/look.zig8
1 files changed, 2 insertions, 6 deletions
diff --git a/src/look.zig b/src/look.zig
index 18fca334..f8c1e24b 100644
--- a/src/look.zig
+++ b/src/look.zig
@@ -919,8 +919,6 @@ pub fn lookHoverPane(p: *const Pardes) ?usize {
}
fn noteLookHover(p: *Pardes, col: u16, row: u16, body_hit: ?Mouse.BodyHit, tag_hit: ?TagHit) void {
- const delay = config.look_preview_delay_frames orelse return;
- _ = delay;
const id = mouse.paneAt(p, col, row) orelse return cancelLookHover(p);
const pane = p.panes[id] orelse return cancelLookHover(p);
_ = edit.pointerTextSelection(p, id, col, row, body_hit, tag_hit) orelse return cancelLookHover(p);
@@ -956,7 +954,7 @@ pub fn refreshLookHoverFromRaw(p: *Pardes) void {
}
pub fn advanceLookHover(p: *Pardes) void {
- const delay = config.look_preview_delay_frames orelse return;
+ const delay = config.look_preview_delay_frames;
const waiting = if (p.look_hover_wait) |*w| w else return;
waiting.frames +|= 1;
if (waiting.frames < delay) return;
@@ -1929,8 +1927,7 @@ pub fn lookAt(p: *Pardes, id: usize, operand_raw: []const u8) void {
}
test "Look hover waits without mutating the pane and input cancels it" {
- const delay = config.look_preview_delay_frames orelse return;
- try std.testing.expect(delay > 0);
+ const delay = config.look_preview_delay_frames;
const gpa = std.testing.allocator;
const p = try Pardes.init(gpa, .{ .cols = 60, .rows = 12, .tty_only = true });
@@ -2064,7 +2061,6 @@ test "cwd changes cancel only the affected pane's Look hover" {
}
test "stationary Look hover follows only acknowledged panel samples" {
- _ = config.look_preview_delay_frames orelse return;
const p = try Pardes.init(std.testing.allocator, .{ .cols = 120, .rows = 20, .tty_only = true });
defer p.deinit();
const pane = p.panes[0].?;