Recent and /recent keep PDFs and images as they keep files, and an open file's row is where its dot is now

Only text files were recorded, so a PDF read yesterday was not there to
find again, and an open file's row showed the place it last closed at,
stale by however far it had moved since. A PDF is kept at its page and
reopened there from its row; an image by its path; an open one's row
reads its pane's place at the time of the listing.

Co-Authored-By: Claude Opus 5.5 <[email protected]>

2 files changed, 24 insertions, 2 deletions

diff --git a/src/ninep/ctl.zig b/src/ninep/ctl.zig
index eff8003b..75a7eb9a 100644
--- a/src/ninep/ctl.zig
+++ b/src/ninep/ctl.zig
@@ -3060,6 +3060,27 @@ test "a Jumplist entry is (closed) only while no pane has its file open" {
     for (p.jumps[0..p.njumps]) |j| try testing.expect(j.serial != 0);
 }
 
+test "Recent's row for a file still open is where its dot is now, not where it last closed" {
+    const p = try withFile(testing.allocator, "x\n");
+    defer p.deinit();
+    var tmp = testing.tmpDir(.{});
+    defer tmp.cleanup();
+    try tmp.dir.writeFile(testing.io, .{ .sub_path = "a.txt", .data = "one\ntwo\nthree\n" });
+    var dir_buf: [4096]u8 = undefined;
+    const dir = dir_buf[0..try tmp.dir.realPath(testing.io, &dir_buf)];
+    var line: [4200]u8 = undefined;
+    try testing.expectEqual(Status.ok, wr(p, root_look, try std.fmt.bufPrint(&line, "{s}/a.txt:3\n", .{dir})).reply.status);
+    p.sync();
+    const pane = p.panes[p.active].?;
+    pane.body.vsel.active = false; // the look's selection of line 3 let go
+    pane.body.cur_row = 1;
+    pane.body.cur_col = 2;
+    try testing.expectEqual(Status.ok, wr(p, root_exec, "Recent\n").reply.status);
+    const rows = p.panes[p.paneBySerial(try std.fmt.parseInt(u32, std.mem.trimEnd(u8, rd(p, root_exec, 0, 64).bytes, "\n"), 10)).?].?;
+    var want: [4300]u8 = undefined;
+    try testing.expect(std.mem.indexOf(u8, rows.file.?.content, try std.fmt.bufPrint(&want, "{s}/a.txt:2:3 open\n", .{dir})) != null);
+}
+
 test "a closed file is found again: Recent and /recent list it closed, a look at its row reopens it at its dot, and a jump back does too" {
     const p = try withFile(testing.allocator, "x\n");
     defer p.deinit();
diff --git a/src/ninep/events.zig b/src/ninep/events.zig
index a09f7278..bacf3ad6 100644
--- a/src/ninep/events.zig
+++ b/src/ninep/events.zig
@@ -140,8 +140,9 @@ pub fn announce(p: *Pardes) void {
         if (!pane.fs.unannounced) continue;
         pane.fs.unannounced = false;
         noteLog(p, .new, pane);
-        // A file opened (a look, a Restore, a boot): first in Recent.
-        if (pane.file) |f| if (f.output == null and pardes.Pardes.recentKeeps(f.path)) p.recent.opened(p.recentGpa(), f.path);
+        // A file, PDF or image opened (a look, a Restore, a boot): first in
+        // Recent.
+        if (pardes.Pardes.recentPlace(pane)) |d| if (pardes.Pardes.recentKeeps(d.path)) p.recent.opened(p.recentGpa(), d.path);
     }
 }