summaryrefslogtreecommitdiff
path: root/src/tty
diff options
context:
space:
mode:
authorGabriel Schneider <[email protected]>2026-09-01 13:46:44 -0300
committerGabriel Schneider <[email protected]>2026-09-01 13:57:41 -0300
commitcce6b18a49870086982f9a0e1fda90ed170b9fba (patch)
treee5ce990d0a1d43503375d891bc51f283e0a1c215 /src/tty
parentae9325a5cb128d0d952afb8f9feaaca68e5e37a2 (diff)
downloadpardes-cce6b18a49870086982f9a0e1fda90ed170b9fba.tar.gz
pardes-cce6b18a49870086982f9a0e1fda90ed170b9fba.zip
macos: one tagline rule for both hosts, a kqueue beside the inotify, and effects that compile
Three things this shell had its own copy of, and in each case the fix is that it stops having one. **The tagline band.** A pane tag draws at `gui_tagline_font_percent` of the body face and the band it sits on shrinks with it, while the grid row stays body-sized — so something has to decide where the shorter band sits in the taller row. This shell decided by centring, always, which is precisely the case `config.gui_topbar_pane_border_px` exists to prevent: the topbar's unused half-band meets the first pane tag's unused half-band and the window background shows through the seam. The strip is as wide as the bands are short — on a 20-pixel cell, 4 physical pixels at the default 82%, 10 at 50%, 14 at 30% — so it grew as the tagline face shrank and read as "the tagline is wrong on the mac" rather than as one missing rule. The rule is `pardes.taglineBandOffset` in the core now and both pixel hosts call it: row zero bottom-aligned, the first pane-tag row top-aligned, the two joined by `gui_topbar_pane_border_px` in the theme's scrollbar-track colour, every row between centred, and a `Tagbottom` band on the final row flush with the window edge — with the sub-cell strip beneath it painted in that band's own colour, because the core grid holds only whole cells and a window is any height it likes. `pardes_tagline_band_offset`, `pardes_topbar_pane_border_px` and `pardes_topbar_pane_border_rgb` carry it over the C ABI as PHYSICAL pixels: the host multiplies its points by the backing scale going in and divides coming out, which is the snapping `Metrics` already does for the cell, and is what keeps a one-pixel rule one pixel instead of a two-pixel smear. **The watch.** `file_watch.zig` was one mark/reconcile transaction over `inotify`, so the tty shell, the SDL window and the detached daemon all watched nothing off Linux: an edit made outside pardes never reached the pane, and a PDF replaced on disk kept rendering the old inode. It is the same transaction over two kernels now — `init`, `wait`, `stop`, `drain`, `markDir` and `unmarkDir` are still the whole of it, and the hosts wait on a kqueue and poll it exactly as they did the old descriptor. A macOS mark is TWO filters, because a kqueue directory filter reports its entries changing and never a write to a file already inside it: the parent mark follows rename-over saves, `markFile` catches in-place writes, and `remarkFile` re-arms the file filter once a rename has moved the inode. That is the same pair the AppKit host's DispatchSources already used for the same reason. Directory marks are deduplicated here by device and inode, because each `EVFILT_VNODE` filter needs a descriptor of its own and inotify did that deduplication itself; `stop` and `drain` wake through the one `EVFILT_USER` filter, since a kqueue cannot simply be read the way an inotify descriptor can. **The effects.** The three `crt.ci.metal` entry points are `extern "C" [[stitchable]]`. `CIKernel.kernels(withMetalString:)` compiles that source at runtime, looks for stitchable functions, and rejects the WHOLE source with "cannot find a valid stitchable Metal function in the source" when it finds none — so `ScenePostprocessor.init?` returned nil and every scene effect and panel transition silently degraded to the plain CoreText draw. The `effect_sources.zig` test pins the exact spelling of all three, and `draw-effect` in the e2e suite catches the degradation rather than the spelling. Beside them, the offscreen harness owes the core a PRESENTATION. Its window is borderless and never ordered front, so AppKit runs no display cycle and `pardes_frame_presented` — whose only caller is `draw(_:)` — never fired. The core holds pointer gestures inert while a layout mutation has not reached a backend, which for an unpresenting harness is the rest of the script: the first pane a script opened silently killed every later click, drag and Look. So `readFrame` presents what it just rendered, into a bitmap nobody reads. `PARDES_CHROME` also looks under `/Applications`, where a browser's executable lives inside an application bundle and never on `PATH`. The macOS goldens are regenerated; docs/macos.md, config.md, detached.md, web.md and the design PDF follow.
Diffstat (limited to 'src/tty')
-rw-r--r--src/tty/tty.zig35
1 files changed, 21 insertions, 14 deletions
diff --git a/src/tty/tty.zig b/src/tty/tty.zig
index f8f7150b..e8a36035 100644
--- a/src/tty/tty.zig
+++ b/src/tty/tty.zig
@@ -11,7 +11,6 @@ const std = @import("std");
const builtin = @import("builtin");
const posix = std.posix;
const libc = std.c;
-const linux = std.os.linux;
const vaxis = @import("vaxis");
const pardes = @import("../pardes.zig");
const tracy = @import("../tracy.zig");
@@ -343,8 +342,8 @@ test "Kitty PDF fragments never declare pixels beyond their clipped bottom" {
try std.testing.expect(kittyPlacement(height, 80, 16, 640, 256) == null);
}
-test "Linux host watch closes initial race and reloads rename-over PDF while idle" {
- if (comptime builtin.os.tag != .linux or !pardes.pdf_enabled) return;
+test "host watch closes initial race and reloads rename-over PDF while idle" {
+ if (comptime !file_watch.supported or !pardes.pdf_enabled) return;
const io = std.testing.io;
const gpa = std.testing.allocator;
var tmp = std.testing.tmpDir(.{});
@@ -361,8 +360,8 @@ test "Linux host watch closes initial race and reloads rename-over PDF while idl
var path_buf: [256]u8 = undefined;
const path = try std.fmt.bufPrint(&path_buf, ".zig-cache/tmp/{s}/live.pdf", .{tmp.sub_path});
- const fd = libc.inotify_init1(linux.IN.CLOEXEC | linux.IN.NONBLOCK);
- if (fd < 0) return error.InotifyInitFailed;
+ const fd = file_watch.init(true);
+ if (fd < 0) return error.WatchInitFailed;
defer _ = libc.close(fd);
var watches: file_watch.Table = @splat(null);
defer for (0..pardes.MAX_PANES) |id| file_watch.watchPane(
@@ -394,9 +393,7 @@ test "Linux host watch closes initial race and reloads rename-over PDF while idl
try std.testing.expectEqual(@as(usize, 1), core.panes[0].?.pdf.?.page_count);
try tmp.dir.rename("live-replacement.pdf", tmp.dir, "live.pdf", io);
- var events: [4096]u8 = undefined;
- const event_bytes = libc.read(fd, &events, events.len);
- try std.testing.expect(event_bytes > 0);
+ try std.testing.expect(file_watch.drain(fd));
// This is the same pass the watcher thread schedules; no key, mouse, or
// synthetic core file_changed event participates in the transaction.
@@ -699,11 +696,12 @@ fn localSession(
.kitty = kitty_handles,
.frame = &frame_arena,
.paste_buf = paste_buf,
- // One inotify instance for every watched pane, opened here — before
- // any thread exists — so the pre-loop effect drain below can already
- // mark the file a positional path argument opened. -1 off linux:
+ // One watcher for every watched pane, opened here — before any thread
+ // exists — so the pre-loop effect drain below can already mark the file
+ // a positional path argument opened. `false`: this host parks a thread
+ // in it rather than polling it. -1 where there is no watcher to make:
// watchPane goes quiet and the core simply never gets a file_changed.
- .inotify_fd = if (builtin.os.tag == .linux) libc.inotify_init1(linux.IN.CLOEXEC) else -1,
+ .inotify_fd = file_watch.init(false),
.fs = fs,
};
// The protocol client's reader threads narrate server state through this
@@ -746,8 +744,10 @@ fn localSession(
sh.lsp_task = null;
}
sh.pipe_tasks.cancelAll(io);
- // same contract as the pty readers: cancel unblocks the watcher's
- // read, and only then is the fd safe to close
+ // same contract as the pty readers: the watcher has to be off the
+ // descriptor before it is closed. `stop` is what releases a kqueue wait
+ // (macos); `cancel` is what interrupts the blocking read (linux).
+ file_watch.stop(sh.inotify_fd);
if (sh.watch_task) |*t| {
t.cancel(io) catch {};
sh.watch_task = null;
@@ -1679,6 +1679,13 @@ fn pipeWorker(
/// per open file pane; filter by basename here if it ever shows up in a
/// profile.
fn watchFiles(io: std.Io, fd: c_int, loop: *Loop) anyerror!void {
+ // A kqueue cannot be read, so there is no std.Io.File to wrap and no
+ // `cancel` to interrupt: this arm parks in kevent(2) and the teardown's
+ // `file_watch.stop` is what releases it. See file_watch.wait.
+ if (comptime builtin.os.tag != .linux) {
+ while (file_watch.wait(fd)) loop.postEvent(.files_changed) catch break;
+ return;
+ }
const file: std.Io.File = .{ .handle = fd, .flags = .{ .nonblocking = false } };
var read_buf: [4096]u8 = undefined;
var reader = file.readerStreaming(io, &read_buf);