A look at a ./ or ../ name that is not there names the file, not the pane's directory

Any relative name that opened nothing was blamed on the pane's directory (look: .../work/many: no such directory) though it exists; the directory is named only when it is gone. A plain name is still looked for as text, its miss logged as any look's.

Co-Authored-By: Claude Opus 5.5 <[email protected]>

2 files changed, 27 insertions, 3 deletions

diff --git a/src/look.zig b/src/look.zig
index f45fe583..236f0687 100644
--- a/src/look.zig
+++ b/src/look.zig
@@ -1470,12 +1470,16 @@ pub fn lookAt(p: *Pardes, id: usize, operand: []const u8) void {
     }
     switch (found) {
         .none => {
-            // `.` or `..` from a pane whose directory is gone: said, ENOENT,
-            // not searched for as a word.
+            // A `./` or `../` name opened nothing: said, ENOENT, not searched
+            // for as a word. What is missing is the pane's directory when
+            // that is gone, else the file named.
             if (filesystem.dotRelative(trimmed)) {
                 const dir = Pardes.paneDir(pane);
                 var said: [4200]u8 = undefined;
-                return p.reportFailure(id, std.fmt.bufPrint(&said, "look: {s}: no such directory", .{dir[0..@min(dir.len, 4096)]}) catch "look: no such directory");
+                const gone = if (comptime pardes.hosted) if (filesystem.localPath(dir)) |local| !exec.isDirectory(local) else false else true;
+                if (gone) return p.reportFailure(id, std.fmt.bufPrint(&said, "look: {s}: no such directory", .{dir[0..@min(dir.len, 4096)]}) catch "look: no such directory");
+                var cut: [miss_path_cap + "…".len]u8 = undefined;
+                return p.reportFailure(id, std.fmt.bufPrint(&said, "look: {s}: no such file", .{missText(trimmed, &cut)}) catch "look: no such file");
             }
             // A raw terminal's clicks are its program's; a look written over
             // 9P is no keyboard input, and searches whatever the key mode.
diff --git a/src/ninep/ctl.zig b/src/ninep/ctl.zig
index a78a9fcd..4b37c23e 100644
--- a/src/ninep/ctl.zig
+++ b/src/ninep/ctl.zig
@@ -2036,6 +2036,26 @@ test "/index shows a name as the log does: a newline in it is \\n, controls spac
     try testing.expect(std.mem.indexOf(u8, rd(p, @intFromEnum(tree.TopFile.index), 0, 4096).bytes, "/tmp/back\\\\nslash") != null);
 }
 
+test "a look at a ./ or ../ name that is not there names the file, ENOENT; a plain one is looked for as text" {
+    const p = try withFile(testing.allocator, "x\n");
+    defer p.deinit();
+    var tmp = testing.tmpDir(.{});
+    defer tmp.cleanup();
+    try tmp.dir.createDirPath(testing.io, "many");
+    var dir_buf: [4096]u8 = undefined;
+    const dir = dir_buf[0..try tmp.dir.realPath(testing.io, &dir_buf)];
+    var line: [4200]u8 = undefined;
+    _ = wr(p, Node.of(serialOf(p), .name), try std.fmt.bufPrint(&line, "{s}/many/a.txt\n", .{dir}));
+    for ([_][]const u8{ "./zz.txt", "../zz.txt" }) |name| {
+        const r = wr(p, Node.of(serialOf(p), .look), try std.fmt.bufPrint(&line, "{s}\n", .{name}));
+        try testing.expectEqual(E.NOENT, r.errno());
+        var want: [64]u8 = undefined;
+        try testing.expectEqualStrings(try std.fmt.bufPrint(&want, "look: {s}: no such file", .{name}), r.reply.ename);
+    }
+    try testing.expectEqual(Status.ok, wr(p, Node.of(serialOf(p), .look), "zz.txt\n").reply.status);
+    try testing.expect(th.logHas(p, "look: no match for \"zz.txt\""));
+}
+
 test "a served-tree pane spoils no Grep, and Look . from a gone directory is ENOENT, not /virtual/" {
     const p = try withFile(testing.allocator, "x\n");
     defer p.deinit();