summaryrefslogtreecommitdiff
path: root/test/macos_e2e.swift
diff options
context:
space:
mode:
authorGabriel Schneider <[email protected]>2026-09-01 13:46:44 -0300
committerGabriel Schneider <[email protected]>2026-09-01 13:57:41 -0300
commitcce6b18a49870086982f9a0e1fda90ed170b9fba (patch)
treee5ce990d0a1d43503375d891bc51f283e0a1c215 /test/macos_e2e.swift
parentae9325a5cb128d0d952afb8f9feaaca68e5e37a2 (diff)
downloadpardes-cce6b18a49870086982f9a0e1fda90ed170b9fba.tar.gz
pardes-cce6b18a49870086982f9a0e1fda90ed170b9fba.zip
macos: one tagline rule for both hosts, a kqueue beside the inotify, and effects that compile
Three things this shell had its own copy of, and in each case the fix is that it stops having one. **The tagline band.** A pane tag draws at `gui_tagline_font_percent` of the body face and the band it sits on shrinks with it, while the grid row stays body-sized — so something has to decide where the shorter band sits in the taller row. This shell decided by centring, always, which is precisely the case `config.gui_topbar_pane_border_px` exists to prevent: the topbar's unused half-band meets the first pane tag's unused half-band and the window background shows through the seam. The strip is as wide as the bands are short — on a 20-pixel cell, 4 physical pixels at the default 82%, 10 at 50%, 14 at 30% — so it grew as the tagline face shrank and read as "the tagline is wrong on the mac" rather than as one missing rule. The rule is `pardes.taglineBandOffset` in the core now and both pixel hosts call it: row zero bottom-aligned, the first pane-tag row top-aligned, the two joined by `gui_topbar_pane_border_px` in the theme's scrollbar-track colour, every row between centred, and a `Tagbottom` band on the final row flush with the window edge — with the sub-cell strip beneath it painted in that band's own colour, because the core grid holds only whole cells and a window is any height it likes. `pardes_tagline_band_offset`, `pardes_topbar_pane_border_px` and `pardes_topbar_pane_border_rgb` carry it over the C ABI as PHYSICAL pixels: the host multiplies its points by the backing scale going in and divides coming out, which is the snapping `Metrics` already does for the cell, and is what keeps a one-pixel rule one pixel instead of a two-pixel smear. **The watch.** `file_watch.zig` was one mark/reconcile transaction over `inotify`, so the tty shell, the SDL window and the detached daemon all watched nothing off Linux: an edit made outside pardes never reached the pane, and a PDF replaced on disk kept rendering the old inode. It is the same transaction over two kernels now — `init`, `wait`, `stop`, `drain`, `markDir` and `unmarkDir` are still the whole of it, and the hosts wait on a kqueue and poll it exactly as they did the old descriptor. A macOS mark is TWO filters, because a kqueue directory filter reports its entries changing and never a write to a file already inside it: the parent mark follows rename-over saves, `markFile` catches in-place writes, and `remarkFile` re-arms the file filter once a rename has moved the inode. That is the same pair the AppKit host's DispatchSources already used for the same reason. Directory marks are deduplicated here by device and inode, because each `EVFILT_VNODE` filter needs a descriptor of its own and inotify did that deduplication itself; `stop` and `drain` wake through the one `EVFILT_USER` filter, since a kqueue cannot simply be read the way an inotify descriptor can. **The effects.** The three `crt.ci.metal` entry points are `extern "C" [[stitchable]]`. `CIKernel.kernels(withMetalString:)` compiles that source at runtime, looks for stitchable functions, and rejects the WHOLE source with "cannot find a valid stitchable Metal function in the source" when it finds none — so `ScenePostprocessor.init?` returned nil and every scene effect and panel transition silently degraded to the plain CoreText draw. The `effect_sources.zig` test pins the exact spelling of all three, and `draw-effect` in the e2e suite catches the degradation rather than the spelling. Beside them, the offscreen harness owes the core a PRESENTATION. Its window is borderless and never ordered front, so AppKit runs no display cycle and `pardes_frame_presented` — whose only caller is `draw(_:)` — never fired. The core holds pointer gestures inert while a layout mutation has not reached a backend, which for an unpresenting harness is the rest of the script: the first pane a script opened silently killed every later click, drag and Look. So `readFrame` presents what it just rendered, into a bitmap nobody reads. `PARDES_CHROME` also looks under `/Applications`, where a browser's executable lives inside an application bundle and never on `PATH`. The macOS goldens are regenerated; docs/macos.md, config.md, detached.md, web.md and the design PDF follow.
Diffstat (limited to 'test/macos_e2e.swift')
-rw-r--r--test/macos_e2e.swift29
1 files changed, 29 insertions, 0 deletions
diff --git a/test/macos_e2e.swift b/test/macos_e2e.swift
index c076aebb..800e2d43 100644
--- a/test/macos_e2e.swift
+++ b/test/macos_e2e.swift
@@ -95,6 +95,8 @@ private final class Driver: PardesViewDelegate {
private var observer: NSObjectProtocol?
private var output = ""
private var nextAnimationFrame: Date?
+ /// Where present() puts the pixels nobody reads.
+ private var presentationRep: NSBitmapImageRep?
/// The script's own file name, for error messages.
private let scriptName: String
@@ -219,6 +221,7 @@ private final class Driver: PardesViewDelegate {
window?.contentView = nil
window = nil
view = nil
+ presentationRep = nil
host.clipboard = nil
host.woke = false
}
@@ -336,6 +339,10 @@ private final class Driver: PardesViewDelegate {
private func readFrame() -> Frame {
let count = pardes_frame()
+ // The core has produced a frame; presenting it is this harness's half of
+ // the contract, and it has to happen AFTER the render rather than before
+ // — see present().
+ defer { present() }
let cols = Int(pardes_frame_cols())
let rows = Int(pardes_frame_rows())
// -1 means hidden. Clamped to 0 rather than printed, which is what
@@ -396,6 +403,28 @@ private final class Driver: PardesViewDelegate {
options: .regularExpression)
}
+ /// Put the frame readFrame() just produced on screen — for a window that has
+ /// no screen, into a bitmap. draw(_:) is the only caller of
+ /// pardes_frame_presented, and this window is deliberately never ordered
+ /// front, so without this nothing here would ever present anything: the core
+ /// would owe a presentation for the rest of the script and correctly hold
+ /// every pointer gesture after the first layout change inert, addressing
+ /// pixels no backend had shown. The app pays the same debt on every pump
+ /// (AppDelegate.pump marks the view, AppKit's display cycle draws it).
+ ///
+ /// The rep is kept and reused rather than allocated per frame: this runs on
+ /// every poll slice, and cacheDisplay only needs somewhere to put pixels
+ /// nobody reads. `draw` makes its own, because it reads them.
+ private func present() {
+ guard let view, view.bounds.width >= 1, view.bounds.height >= 1 else { return }
+ let bounds = view.bounds
+ if presentationRep?.size != bounds.size {
+ presentationRep = view.bitmapImageRepForCachingDisplay(in: bounds)
+ }
+ guard let rep = presentationRep else { return }
+ view.cacheDisplay(in: bounds, to: rep)
+ }
+
/// Render the view the way AppKit would and prove the CoreText pass put
/// something on the screen. `snap` reads the core's cell buffer and would be
/// perfectly happy with a draw(_:) that returned on its first line; this is