summaryrefslogtreecommitdiff
path: root/src
diff options
context:
space:
mode:
authorGabriel Schneider <[email protected]>2026-11-17 08:01:22 -0300
committerGabriel Schneider <[email protected]>2026-11-17 12:15:01 -0300
commitf0c4ef1a771f6b13cbd86cccdb56accfd39bbd69 (patch)
tree15574741d6e9d6866ef64c0fb3033e3b69cd9aaf /src
parentfb237529724ae1c01b15f99e3b25bdce7c77cf82 (diff)
downloadsketchbook-f0c4ef1a771f6b13cbd86cccdb56accfd39bbd69.tar.gz
sketchbook-f0c4ef1a771f6b13cbd86cccdb56accfd39bbd69.zip
gpu: a uniform block over 4096 bytes fails to compile
SDL_GPU's Vulkan backend binds 4 KiB of a uniform block (its descriptors' range, MAX_UBO_SECTION_SIZE in SDL_gpu_vulkan.c) and a larger block was cut off without a word, the rest of it read as nothing: examples/live met it with its two tapes in one block. glsl.assertStd140, which `gpu.uniform` and the GLSL layouts of a `.uniform` type both run, now refuses a block past `max_uniform_block` (4096) at compile time, the error naming the type, its size and the storage buffer to use instead. The README says so where it says std140 is checked. Test: a 4096-byte block passes (glsl.zig); a 4112-byte one fails to compile with the message, checked by hand (there is no harness for compile errors). zig build test: 186 of 186 steps, 148 of 148 tests. Co-Authored-By: Claude Opus 5.5 <[email protected]> Claude-Session: https://claude.ai/code/session_016Y9MNBECMWcJD5pdS4SR6T
Diffstat (limited to 'src')
-rw-r--r--src/glsl.zig13
1 files changed, 12 insertions, 1 deletions
diff --git a/src/glsl.zig b/src/glsl.zig
index a1cd2d6..974f566 100644
--- a/src/glsl.zig
+++ b/src/glsl.zig
@@ -98,12 +98,19 @@ pub fn generate(comptime root: type, comptime paths: []const []const u8, io: std
}
}
+/// The most bytes a uniform block holds: what SDL_GPU's Vulkan backend
+/// binds of one (its descriptors' range, MAX_UBO_SECTION_SIZE); a larger
+/// block was cut off without a word (examples/live's two tapes met it).
+pub const max_uniform_block = 4096;
+
/// Fails to compile unless `U` lays out exactly as a std140 uniform block
/// with the same members in GLSL: scalars at 4 bytes, `vec2` at 8,
-/// `vec3`/`vec4` at 16, arrays and nested structs at 16 with 16-byte strides.
+/// `vec3`/`vec4` at 16, arrays and nested structs at 16 with 16-byte strides;
+/// and fits `max_uniform_block`.
pub fn assertStd140(comptime U: type) void {
comptime {
if (@typeInfo(U).@"struct".layout != .@"extern") @compileError(@typeName(U) ++ " must be extern to be a uniform block");
+ if (@sizeOf(U) > max_uniform_block) @compileError(std.fmt.comptimePrint("{s} is {d} bytes: a uniform block is {d} at most (SDL_GPU's Vulkan backend binds 4 KiB of one, MAX_UBO_SECTION_SIZE, and the rest reads as nothing); put the rest in a storage buffer", .{ @typeName(U), @sizeOf(U), max_uniform_block }));
const s = @typeInfo(U).@"struct";
for (s.field_names, s.field_types) |name, F| {
const want = std140Align(F);
@@ -136,6 +143,10 @@ fn std140Align(comptime T: type) usize {
};
}
+test "a uniform block of 4096 bytes is one (4112 fails to compile, as a lone check showed)" {
+ comptime assertStd140(extern struct { a: [256][4]f32 });
+}
+
test "uniform blocks and vertex inputs from structs" {
const Root = struct {
pub const Paint = extern struct {